Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use electron store #2644

Merged
merged 2 commits into from
Jan 22, 2025
Merged

fix: use electron store #2644

merged 2 commits into from
Jan 22, 2025

Conversation

hyoban
Copy link
Member

@hyoban hyoban commented Jan 22, 2025

Description

PR Type

  • Feature
  • Bugfix
  • Hotfix
  • Other (please describe):

Screenshots (if UI change)

Demo Video (if new feature)

Linked Issues

try fix #2473

Additional context

Changelog

  • I have updated the changelog/next.md with my changes.

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
follow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 2:27pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
follow-external-ssr ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 2:27pm

@follow-reviewer-bot
Copy link

Suggested PR Title:

chore: update dependencies and refactor store handling

Change Summary:
Updated package dependencies and improved store handling to use electron-store. Refactored store methods, fixed default values for credentials, and enhanced proxy setting handling, leading to more robust data management and application behavior.

Code Review:

  • apps/main/src/init.ts
    • Line 154: The change from credentials || null to credentials || undefined might introduce unexpected behavior if the consuming code expects null when credentials are not set. Ensure that all parts of the codebase that consume this attribute are checked and compatible with this change from null to undefined.

No other change requests necessary.

@hyoban hyoban marked this pull request as ready for review January 22, 2025 14:27
@hyoban hyoban merged commit 9f30194 into dev Jan 22, 2025
10 checks passed
@hyoban hyoban deleted the fix/try-electron-store branch January 22, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

You have to log in again every time you log in.
1 participant