bsp: cvitek: use rttpkgtool for aarch64 #10129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unicornx
suggested changes
Mar 19, 2025
There was a problem hiding this comment.
除了这里新的 comments，上次提的 comments 里有两条你没有纠正：
Q4：bsp/cvitek/cv18xx_aarch64/README.md 需要相应修改。 有关现有操作步骤，你还可以参考 https://github.com/plctlab/plct-rt-thread/blob/notes/0.notes/20241223-rtt-test-guide.md 中的 case 2 “RV64 小核 & AARCH64 大核” 的描述。
Q5: 把 PR 和 9968 关联一下, 仔细看一下 https://github.com/plctlab/plct-rt-thread/blob/notes/0.notes/20241212-github-tips.md#3-things-to-note-when-submitting-pr-to-rt-thread
bsp/cvitek/build.sh
Outdated
| echo " -h: display usage" | ||
| echo " -l: build c906L" | ||
| echo " -b: build c906B" | ||
| echo " -a: build Cortex-A53" |
bsp/cvitek/build.sh
Outdated
| while getopts ":hbl" opt | ||
| function build_A53() { | ||
| echo "build_A53" | ||
| echo "BOARD_TYPE: duo256m" |
There was a problem hiding this comment.
这两行合并成一行echo，例如：echo "build_a53 for duo256m"
bsp/cvitek/build.sh
Outdated
| @@ -28,7 +29,14 @@ function build_c906l() { | |||
| DPT_PATH_KERNEL=$BSP_PATH/../../ DPT_BOARD_TYPE=$BOARD_TYPE DPT_PATH_OUTPUT=$BSP_PATH/output ./rttpkgtool/script/mkpkg.sh -l | |||
| } | |||
|
|
|||
| while getopts ":hbl" opt | |||
| function build_A53() { | |||
|
新的改动可以直接继续使用这个 PR，不必关闭新开。代码修改后记得 rebase 压缩成一个 commit 后 force push 到原来的开发分支即可，修改后记得发起 request review。 |
|
Accept |
jojoandgyc
force-pushed
the
use_rttpkgtool_for_aarch64
branch
from
4ad41ef to
ef476dd
Compare
1.Using scripts in rttpkgtool to make firmware. 2.Deleted duplicate prebuild files. RT-Thread#9968 3.modify README.md Signed-off-by: YunZhan Huang <[email protected]>
jojoandgyc
force-pushed
the
use_rttpkgtool_for_aarch64
branch
from
ef476dd to
74d059d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #9968
1.Using scripts in rttpkgtool to make firmware.
2.Deleted duplicate prebuild files.
拉取/合并请求描述：(PR description)
[
为什么提交这份PR (why to submit this PR)
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up