-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[bsp/hpm5300evk]: 修复readme中的描述问题 #10187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.bsp中描述路径boards不存在,只有board,并且路径中会包含openocd,把openocd路径去掉 2. 运行openocd发现cmsis-dap.cfg异常,使用ft2232.cfg可以正常烧入,修改readme 3. 添加download.bat脚本,方便下载
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (1)
- bsp/hpmicro/hpm5300evk/download.bat: Language not supported
Comments suppressed due to low confidence (2)
bsp/hpmicro/hpm5300evk/README_zh.md:74
- Ensure that changing the directory from 'boards' to 'board' and updating the probe config file to 'ft2232.cfg' correctly reflects the actual file structure and configuration requirements.
%OPENOCD_HPMICRO%\openocd.exe -f board\debug_scripts\probes\ft2232.cfg -f board\debug_scripts\soc\hpm5300.cfg -f board\debug_scripts\boards\hpm5300evk.cfg -c "init; halt; flash write_image erase rtthread.elf; reset; shutdown"
bsp/hpmicro/hpm5300evk/README_zh.md:81
- Update the debug command to use the correct directory and configuration file so it is consistent with the flashing command.
%OPENOCD_HPMICRO%\openocd.exe -f board\debug_scripts\probes\ft2232.cfg -f board\debug_scripts\soc\hpm5300.cfg -f board\debug_scripts\boards\hpm5300evk.cfg
Rbb666
approved these changes
Apr 13, 2025
Lin-Chengqiu
pushed a commit
to Lin-Chengqiu/rt-thread
that referenced
this pull request
Apr 14, 2025
add RT_THREAD_CTRL_SET_PRIORITY add RT_THREAD_CTRL_SET_PRIORITY doxygen: cleanup and re-org files This patch contains two small changes, mainly to prepare for the next step of organizing the modules framework. The first change: move the files related to doxygen examples to `documentation/0.doxygen/example/` The second change: delete `documentation/0.doxygen/mainpage.h`, which is the mainpage of the old page. Now the new mainpage is `documentation/INDEX.md`, so the duplicate can be deleted. Signed-off-by: Chen Wang <[email protected]> [bsp/hpm5300evk]: 修复readme中的描述问题 (RT-Thread#10187) 1.bsp中描述路径boards不存在,只有board,并且路径中会包含openocd,把openocd路径去掉 2. 运行openocd发现cmsis-dap.cfg异常,使用ft2232.cfg可以正常烧入,修改readme 3. 添加download.bat脚本,方便下载 libcpu: aarch64: Fix NORMAL_NOCACHE_MEM attr (RT-Thread#10180) Signed-off-by: Cliff Chen <[email protected]> Signed-off-by: mouch6131 <[email protected]> Co-authored-by: Cliff Chen <[email protected]> Fixed an error by running scons --tartget=cmake under LINUX, RT-Thread#10113 (RT-Thread#10164) Fixed an error by running scons --tartget=cmake under LINUX, and associated issue RT-Thread#10113
Lin-Chengqiu
pushed a commit
to Lin-Chengqiu/rt-thread
that referenced
this pull request
Apr 14, 2025
add RT_THREAD_CTRL_SET_PRIORITY add RT_THREAD_CTRL_SET_PRIORITY doxygen: cleanup and re-org files This patch contains two small changes, mainly to prepare for the next step of organizing the modules framework. The first change: move the files related to doxygen examples to `documentation/0.doxygen/example/` The second change: delete `documentation/0.doxygen/mainpage.h`, which is the mainpage of the old page. Now the new mainpage is `documentation/INDEX.md`, so the duplicate can be deleted. Signed-off-by: Chen Wang <[email protected]> [bsp/hpm5300evk]: 修复readme中的描述问题 (RT-Thread#10187) 1.bsp中描述路径boards不存在,只有board,并且路径中会包含openocd,把openocd路径去掉 2. 运行openocd发现cmsis-dap.cfg异常,使用ft2232.cfg可以正常烧入,修改readme 3. 添加download.bat脚本,方便下载 libcpu: aarch64: Fix NORMAL_NOCACHE_MEM attr (RT-Thread#10180) Signed-off-by: Cliff Chen <[email protected]> Signed-off-by: mouch6131 <[email protected]> Co-authored-by: Cliff Chen <[email protected]> Fixed an error by running scons --tartget=cmake under LINUX, RT-Thread#10113 (RT-Thread#10164) Fixed an error by running scons --tartget=cmake under LINUX, and associated issue RT-Thread#10113 [DM/FDT] Fix garble when booting Fix garble caused by empty implementation of earlycon series function in driver.If driver doesn't offer earlycon_id or rt_f dt_earlycon_id.setup function but open option, the checking of best_earlycon_id will failed. Signed-off-by: 1078249029 <[email protected]> [bsp/phytium]适配rtthread5.2版本 (RT-Thread#10178) * rtthread 5.2适配
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.bsp中描述路径boards不存在,只有board,并且路径中会包含openocd,把openocd路径去掉
2. 运行openocd发现cmsis-dap.cfg异常,使用ft2232.cfg可以正常烧入,修改readme
3. 添加download.bat脚本,方便下载
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
修复readme中的描述异常
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up