Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codebase Cleanup, Badger Query Optimization, PostgreSQL Index Creation #12

Merged
merged 13 commits into from
May 18, 2020

Conversation

bonedaddy
Copy link
Contributor

@bonedaddy bonedaddy commented May 10, 2020

  • Slightly optimize badger query function
  • Add testutils package, closing Add Testutils Package #15
  • Enable index creation for postgres as an optional functionality

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #12 into master will increase coverage by 1.51%.
The diff coverage is 86.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage   80.40%   81.91%   +1.51%     
==========================================
  Files           7        8       +1     
  Lines         653      630      -23     
==========================================
- Hits          525      516       -9     
+ Misses         91       80      -11     
+ Partials       37       34       -3     
Impacted Files Coverage Δ
badger/datastore.go 71.81% <ø> (-1.09%) ⬇️
sql/postgres/postgres.go 88.41% <77.78%> (-1.75%) ⬇️
badger/query.go 87.50% <87.50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77686be...29bfd3a. Read the comment docs.

@bonedaddy bonedaddy changed the title Badger Optimization Codebase Cleanup, Badger Query Optimization, PostgreSQL Index Creation May 13, 2020
sql/README.md Outdated Show resolved Hide resolved
sql/README.md Outdated Show resolved Hide resolved
sql/postgres/postgres.go Outdated Show resolved Hide resolved
@bonedaddy bonedaddy requested a review from xiegeo May 17, 2020 22:21
Copy link
Contributor

@xiegeo xiegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now, the docs aren't very clear on when existing tables are deleted. Does it happen every time when the option is set, or only if the old table is not structured correctly?

@bonedaddy
Copy link
Contributor Author

Good point I will update the docs. The tables are only deleted when RecreateTables is set, and the warning is accepted

@bonedaddy bonedaddy merged commit bc2b375 into master May 18, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2020
@xiegeo
Copy link
Contributor

xiegeo commented May 18, 2020

Good point I will update the docs. The tables are only deleted when RecreateTables is set, and the warning is accepted

So if the option is set and waring accepted, then the tables are always recreated on every program start?

@bonedaddy
Copy link
Contributor Author

So if the option is set and waring accepted, then the tables are always recreated on every program start?

Yes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants