Final Group Capstone

[Kwentsir]

In this PR, the following were implemented;

• Set up the repository/repositories on GitHub and used Gitflow.

• Postgres used as a database

• Used Rails to create backend API.

• Used React & Redux to create frontend UI.

Frontend URL - https://github.com/RWUBAKWANAYO/motorbike_booking_frontend
Frontend Live Demo - https://motorbike-booking.netlify.app/

[Meltrust]

Hi @Kwentsir,

Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation, but you are almost there!

To highlight:

• Nice docs✔️
• Nice readme✔️
• The API runs well ✔️

Suggested Changes ♻️

Check the comments under the review.

There is no open pull request on the frontend project so I'll leave my comments here. For the next review, kindly leave a PR open on both projects. The PR should point to dev => main.

• The license link on the readme is broken because it points to a file that does not exist. Kindly fix this link.
• The app has no tests. Please, add some tests to ensure the integrity and functionality of your app.
• The default React test still exists on the project App.test.js kindly delete this file as it is not needed.
• There are at least 3 instances where you are using the function keyword. This has been soft deprecated in the software industry and we've all moved to ES6 and arrow functions. Kindly refactor these functions to be ES6, so your app complies with the latest standards.
• The reservation functionality does not work yet. On prod, I get kicked out of the app. On dev, nothing happens and no reservation takes place.
• I couldn't find a way to log out.
• OPTIONAL This is just a warning. Your app does not seem to start on Firefox (blank page).

You can use as many of my suggestions as you want. If there is anything you would like to skip - feel free to do that. However, I strongly recommend you take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

[Meltrust]

• This license link is broken, because it points to a file that does not exist. Please, kindly fix this link so your users can follow it if needed.

[Meltrust]

• Tests are not running on my end. Please check if they are running on your env, and if the don't, please fix them to ensure the integrity of your app.

[Meltrust]

• You are using Rspec, however the test folder still exists, which is used for another test framework.

Please, consider deleting this folder if you are not using it.

[Meltrust]

Hi @Kwentsir,

Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation, but you are almost there!

To highlight:

• Most tests are passing✔️
• App is working ✔️
• Good readme! ✔️

Suggested Changes ♻️

Check the comments under the review.

You can use as many of my suggestions as you want. If there is anything you would like to skip - feel free to do that. However, I strongly recommend you take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

[Meltrust]

• I can run the tests now, however 20 are failing:

It seems the problematic tests are the ones that expect a response (e.g. 200)

Please, debug those tests to ensure the integrity of your app.