Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the card component to follow the new design #294

Merged
merged 4 commits into from
Sep 13, 2020

Conversation

cecastosic
Copy link
Contributor

#81
updated the card component in the storybook
added new components: role, card section
changed all names for all files in the components folder to follow the same rule

Screenshots from Storybook:
Screenshot 2020-06-30 at 00 49 09
Screenshot 2020-06-30 at 00 49 03
Screenshot 2020-06-30 at 00 48 52

Copy link
Contributor

@diwanow diwanow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some recommendations, we can discuss further.

my-app/src/components/Card/Card.css Outdated Show resolved Hide resolved
my-app/src/components/Card/Card.css Outdated Show resolved Hide resolved
my-app/src/components/Card/Card.css Outdated Show resolved Hide resolved
my-app/src/stories/stories.js Outdated Show resolved Hide resolved
my-app/src/components/card/card.component.js Outdated Show resolved Hide resolved
my-app/src/index.css Outdated Show resolved Hide resolved
my-app/src/components/card/card.component.js Outdated Show resolved Hide resolved
my-app/src/components/card/card.component.js Outdated Show resolved Hide resolved
Copy link
Contributor

@diwanow diwanow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for considering all my previous comments. I added 2-3 new and tried to answer your questions.

my-app/src/stories/stories.js Outdated Show resolved Hide resolved
my-app/src/components/userCard/user-card.component.js Outdated Show resolved Hide resolved
my-app/src/components/link/link.component.js Show resolved Hide resolved
my-app/src/components/name/name.component.js Outdated Show resolved Hide resolved
my-app/src/components/name/name.component.js Outdated Show resolved Hide resolved
my-app/src/index.css Outdated Show resolved Hide resolved
Copy link
Contributor

@diwanow diwanow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized I didn't approve only commented. My last comments are rather small. @cecastosic when do you think you will have time to close this down?

@cecastosic
Copy link
Contributor Author

cecastosic commented Sep 12, 2020

@diwanow Done 🙂 I will make a new PR with Prettier configuration 🙂

Copy link
Contributor

@diwanow diwanow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@cecastosic cecastosic merged commit 953b238 into master Sep 13, 2020
@cecastosic cecastosic deleted the storybook/card branch September 13, 2020 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants