-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the card component to follow the new design #294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some recommendations, we can discuss further.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for considering all my previous comments. I added 2-3 new and tried to answer your questions.
my-app/src/components/userCardSection/user-card-section.component.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized I didn't approve only commented. My last comments are rather small. @cecastosic when do you think you will have time to close this down?
08e9049
to
bbdb29e
Compare
@diwanow Done 🙂 I will make a new PR with Prettier configuration 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
#81
updated the card component in the storybook
added new components: role, card section
changed all names for all files in the components folder to follow the same rule
Screenshots from Storybook: