Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed hamburger menu in component category pages #601

Closed
wants to merge 0 commits into from

Conversation

pb0126
Copy link
Contributor

@pb0126 pb0126 commented Feb 22, 2024

Fixes Issue🛠️

Closes #592

Description👨‍💻

The hamburger menu was not working on the component category page, after adding js files to the page it was working fine.

Type of change📄

  • Bug fix (non-breaking change which fixes an issue)

How this has been tested✅

The changes has been through tested by visiting one by one and using Chrome Developer tools

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added demonstration in the form of GIF/video file
  • I am an Open Source Contributor

Screenshots/GIF📷

image

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pb0126, Welcome to the project Beautiify! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

Copy link

netlify bot commented Feb 22, 2024

Deploy Preview for beautiify ready!

Name Link
🔨 Latest commit 765991e
🔍 Latest deploy log https://app.netlify.com/sites/beautiify/deploys/65d8703007d888000879be20
😎 Deploy Preview https://deploy-preview-601--beautiify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Rakesh9100
Copy link
Owner

As told in the PR you closed to make the space same between Contributors and Contact for every pages, pls see and do the changes in this PR only. Not needed to close the previous PR or this PR now @pb0126

image

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label Feb 23, 2024
@Rakesh9100 Rakesh9100 changed the title Fixes#592 Hamburger menu nav list and button fixed Fixed hamburger menu in component category pages Feb 23, 2024
@pb0126 pb0126 closed this Feb 23, 2024
@Rakesh9100
Copy link
Owner

Can I know why are you closing the PRs again and again, as you can make any changes in the same PR @pb0126

@pb0126
Copy link
Contributor Author

pb0126 commented Feb 23, 2024

I have discarded the commit as I have other issues fixed, they are also lining up with them.

@pb0126
Copy link
Contributor Author

pb0126 commented Feb 23, 2024

Also, I want to know where is the problem coming, I have fixed the margin between the components and contact

@Rakesh9100
Copy link
Owner

You can check all the components category pages and figure out the problem @pb0126

@Rakesh9100 Rakesh9100 removed the question 🤔 Further information is requested label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Hamburger menu not working in component category pages
2 participants