Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed hamburger menu in component category pages #605

Merged
merged 12 commits into from
Mar 1, 2024

Conversation

pb0126
Copy link
Contributor

@pb0126 pb0126 commented Feb 23, 2024

Fixes Issue🛠️

Closes #592

Description👨‍💻

The hamburger menu was not working on the component category page, after adding js files to the page it was working fine. The margin between contact and contributors page fixed

Type of change📄

  • Bug fix (non-breaking change which fixes an issue)

How this has been tested✅

The changes has been through tested by visiting one by one and using Chrome Developer tools

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added demonstration in the form of GIF/video file
  • I am an Open Source Contributor

Screenshots/GIF📷

image

Copy link

netlify bot commented Feb 23, 2024

Deploy Preview for beautiify ready!

Name Link
🔨 Latest commit 4e1b8a4
🔍 Latest deploy log https://app.netlify.com/sites/beautiify/deploys/65d877146df40d00088b25cc
😎 Deploy Preview https://deploy-preview-605--beautiify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pb0126, Welcome to the project Beautiify! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@pb0126 pb0126 changed the title Fixes Fixes#592 Hamburger menu on small device and margins fixed Feb 23, 2024
@Rakesh9100 Rakesh9100 changed the title Fixes#592 Hamburger menu on small device and margins fixed Fixed hamburger menu in component category pages Feb 23, 2024
@pb0126
Copy link
Contributor Author

pb0126 commented Feb 27, 2024

Hi, @Rakesh9100, Can you please look into this and merge it

@Rakesh9100
Copy link
Owner

Merged 🎉 @pb0126

@Rakesh9100 Rakesh9100 merged commit dd553dd into Rakesh9100:main Mar 1, 2024
4 checks passed
@Rakesh9100 Rakesh9100 added SWOC S4 SWOC Open Source Program Easy IWOC2k24 (10 Points) ✨, JWOC2k24 (1 Point) 🎉, SWOC2k24 Level-1 (20 Points) 💫 Completed 🥳 PR successfully merged and issue resolved on completion labels Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion Easy IWOC2k24 (10 Points) ✨, JWOC2k24 (1 Point) 🎉, SWOC2k24 Level-1 (20 Points) 💫 SWOC S4 SWOC Open Source Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Hamburger menu not working in component category pages
2 participants