Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added search icon in every search bar #829

Closed
wants to merge 3 commits into from

Conversation

soniya-malviy
Copy link

@soniya-malviy soniya-malviy commented May 30, 2024

Fixes Issue🛠️

Closes #820

Description👨‍💻

Added search icon where user will search Component Name (placeholder: Enter Component Name).

Type of change📄

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How this has been tested✅

Tested locally.

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added demonstration in the form of GIF/video file
  • I am an Open Source Contributor

Screenshots/GIF📷

Before the PR:

Image 30-05-24 at 6 25 PM

After the PR:

Image 30-05-24 at 6 25 PM (1)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @soniya-malviy, Welcome to the project Beautiify! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

Copy link

netlify bot commented May 30, 2024

Deploy Preview for beautiify ready!

Name Link
🔨 Latest commit 1abbc1b
🔍 Latest deploy log https://app.netlify.com/sites/beautiify/deploys/66598eca0e64520009af90a4
😎 Deploy Preview https://deploy-preview-829--beautiify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Rakesh9100 Rakesh9100 changed the title Added search icon search bar which looks good and attractive to user. Added search icon in every search bar May 30, 2024
@Rakesh9100
Copy link
Owner

Pls add to every components category pages as well @soniya-malviy

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label May 30, 2024
@soniya-malviy
Copy link
Author

Pls add to every components category pages as well @soniya-malviy

sure.Rakesh9100.

@soniya-malviy
Copy link
Author

soniya-malviy commented May 31, 2024 via email

@saurabhsingh720
Copy link

@soniya-malviy
Check responsiveness of that icon.

@Rakesh9100
Copy link
Owner

Yes, the icon is not responsive as well as the website is distorted @soniya-malviy

@Rakesh9100 Rakesh9100 closed this Jun 6, 2024
@Rakesh9100 Rakesh9100 removed the question 🤔 Further information is requested label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add search icon in every search bar
3 participants