Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add in creature endpoint PWL and refactor creature variant #62

Merged
merged 12 commits into from
Jul 22, 2024
Merged

feat: Add in creature endpoint PWL and refactor creature variant #62

merged 12 commits into from
Jul 22, 2024

Conversation

RakuJa
Copy link
Owner

@RakuJa RakuJa commented Jul 18, 2024

  • add pwl for single creature fetch (base,weak,elite);
  • update dockerfile to avoid warnings
  • rename OptionalData to ResponseDataModifiers
  • expand variant logic to all the fields and not just hp, level, link;
  • align bybe to the new db structure, with weapon/shield/armor traits & weapon/shield/armor creature association

RakuJa added 8 commits July 11, 2024 20:15
@RakuJa
feat:
cabe17d 
* add pwl for single creature fetch (base,weak,elite);
* update dockerfile to avoid warnings
* rename OptionalData to ResponseDataModifiers
@RakuJa
feat:
ff2ee30 
* update variant logic to modify more fields;
* fix wrong hp level in variant logic;
* fix wrong modifier sum in pwl/variant logic.
@RakuJa
fix: get item not working for shield
9ecffd5
@RakuJa
Merge branch 'refs/heads/add_pwl_to_creature_endpoint' into expand_cr…
5e7e41f 
…eature_variant
@RakuJa
fix: item duplicates
a8b8bbc
@RakuJa
fix: pwl inverted boolean
8bc156f
@RakuJa
chore: modify core level for variant
1d57ba2
@RakuJa
feat: improve variant parsing, item traits and duplicates
9835663 
* expand dice logic to weapon damage data
* handle separate weapon/shield/armor creature association
* handle separate weapon/shield/armor trait association
* fix elite level -1
* get avg now is implemented in dice and can handle a weapon with multiple damage sources
*
@RakuJa RakuJa added bug Something isn't working enhancement New feature or request bestiary shop labels Jul 18, 2024
@RakuJa RakuJa requested a review from TheAsel July 18, 2024 13:10
@RakuJa RakuJa self-assigned this Jul 18, 2024
This was linked to issues Jul 18, 2024
Add PwL parameter to /bestiary/*/{creature_id} endpoint #54
Closed
Incomplete creature's changes for Weak and Elite variants #55
Closed
@RakuJa
chore: rename shoptype to shoptemplate, fix some small bugs in random…
c974573 
… shop generation and forged item calculation
TheAsel
TheAsel approved these changes Jul 20, 2024
View reviewed changes
Copy link
Collaborator

@TheAsel TheAsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RakuJa RakuJa merged commit e0d3727 into add_item_endpoint Jul 22, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheAsel TheAsel TheAsel approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@RakuJa RakuJa

Labels
bestiary bug Something isn't working enhancement New feature or request shop
Projects
None yet
Milestone
No milestone
2 participants
@RakuJa @TheAsel