Feature/enhance #70
Merged
Feature/enhance #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most projects have their own base classes. Although these base classes can inherit from RAKBase.BaseXXX, when the base class of a project is in a framework and the main project references both RAKBase and this project, you must specify the ownership of BaseXXX. This is a hassle for the caller. Most of the time, RAKBase.BaseXXX will only be used once, so renaming it would be a clearer choice.
In previous versions, NavigationControllerPopDelegateProxy only used the public annotation, and the caller could not inherit from NavigationControllerPopDelegateProxy. This submission adds the final modifier to make it clear that this cannot be inherited.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.