Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Landing Text Style #287

Closed
wants to merge 1 commit into from
Closed

Conversation

neeru24
Copy link

@neeru24 neeru24 commented Oct 14, 2024

Description:

  • Decreased the font size of the heading "A unique café experience awaits you" to enhance visual appeal and maintain balance within the layout.
  • Added a subtle hover effect that applies a brown glow to the text to match the theme, improving interactivity and user engagement.

- Changes Made:

  • Updated font size.
  • Implemented onMouseOver and onMouseOut event handlers for the text to add a scaling effect and glow on hover.

KINDLY MERGE IT and fixes: #281

Summary by CodeRabbit

  • New Features

    • Enhanced interactivity of the main heading with mouse hover effects, including scaling and color changes.
  • Style

    • Updated styling for the main heading to improve visual appeal and engagement.

Copy link

vercel bot commented Oct 14, 2024

@neeru24 is attempting to deploy a commit to the bunty's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Oct 14, 2024

Walkthrough

The Landing component in frontend/src/components/ui/Landing.jsx has been updated to enhance the styling and interactivity of the main heading. The <h1> element's class name has been modified, and inline styles have been added to adjust its font size and color. New mouse event handlers have been introduced to improve interactivity, allowing the heading to scale and change color on hover. The overall structure of the component remains unchanged, preserving existing functionality.

Changes

File Change Summary
frontend/src/components/ui/Landing.jsx Updated <h1> class name and inline styles, added mouse event handlers for interactivity.

Assessment against linked issues

Objective Addressed Explanation
Decrease the font size for the "A Unique Café Experience" text (281)
Ensure that the phrase fits on one line without breaking (281) The font size was set but not decreased as required.

Possibly related PRs

Suggested labels

level 2, gssoc-ext

Suggested reviewers

  • RamakrushnaBiswal

Poem

In the land of code where rabbits play,
The heading shines bright, in a brand new way.
With colors that dance and shadows that gleam,
A unique café experience, like a sweet dream! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 99c2b0d and dccffd6.

📒 Files selected for processing (1)
  • frontend/src/components/ui/Landing.jsx (1 hunks)
🧰 Additional context used
🔇 Additional comments (1)
frontend/src/components/ui/Landing.jsx (1)

42-62: Great implementation of hover effects, but consider these improvements:

The changes successfully implement the requested font size adjustment and hover effects, addressing the objectives mentioned in the PR summary and issue #281. However, there are a few areas that could be improved:

  1. Responsiveness:
    The fixed font size of 4rem might not be responsive across all screen sizes. Consider using responsive units or media queries to ensure the text remains appropriately sized on different devices.

  2. Accessibility:

    Please verify that the color contrast between the text (BUG: Heroimage section responsiveness #333 and #4e2c0a) and the background meets WCAG 2.1 Level AA standards for accessibility.

  3. Performance:
    While the hover effects enhance interactivity, using inline styles for these effects might impact performance, especially on low-end devices. Consider moving these styles to a CSS class and toggling the class on hover for better performance.

Here's a suggested refactor to address these concerns:

+import styles from './Landing.module.css';  // Create this CSS module file

 <h1 
-  className="unique-text ml-4" 
+  className={`${styles.uniqueText} ml-4`}
   ref={textRef}
-  style={{
-    fontSize: '4rem',
-    fontWeight: 'bold',
-    textAlign: 'center',
-    color: '#333',
-    transition: 'transform 0.3s ease, text-shadow 0.3s ease, color 0.3s ease',
-  }}
-  onMouseOver={(e) => {
-    e.currentTarget.style.transform = 'scale(1.05)';
-    e.currentTarget.style.color = '#4e2c0a';
-    e.currentTarget.style.textShadow = '0 0 5px rgba(78, 44, 10, 0.6), 0 0 10px rgba(78, 44, 10, 0.4)';
-  }}
-  onMouseOut={(e) => {
-    e.currentTarget.style.transform = 'scale(1)';
-    e.currentTarget.style.color = '#333';
-    e.currentTarget.style.textShadow = 'none';
-  }}
+  onMouseOver={(e) => e.currentTarget.classList.add(styles.hovered)}
+  onMouseOut={(e) => e.currentTarget.classList.remove(styles.hovered)}
 >
   A unique café experience awaits you
 </h1>

Then in Landing.module.css:

.uniqueText {
  font-size: clamp(2rem, 5vw, 4rem);
  font-weight: bold;
  text-align: center;
  color: #333;
  transition: transform 0.3s ease, text-shadow 0.3s ease, color 0.3s ease;
}

.uniqueText.hovered {
  transform: scale(1.05);
  color: #4e2c0a;
  text-shadow: 0 0 5px rgba(78, 44, 10, 0.6), 0 0 10px rgba(78, 44, 10, 0.4);
}

@media (max-width: 768px) {
  .uniqueText {
    font-size: clamp(1.5rem, 4vw, 3rem);
  }
}

This refactor improves responsiveness, moves styles to a CSS module for better performance, and maintains the desired hover effects.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
play-cafe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 2:29am

@RamakrushnaBiswal
Copy link
Owner

@neeru24 its doesn't looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Adjust Font Size for "A Unique Café Experience" to Fit well
2 participants