Added Newsletter-Form #375
Conversation
|
Warning Rate limit exceeded@meghanakn473 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 39 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe changes in this pull request involve the addition of a newsletter feature in both the backend and frontend of the application. A new route is introduced in Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
|
@meghanakn22 is attempting to deploy a commit to the bunty's projects Team on Vercel. A member of the Team first needs to authorize it. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Outside diff range and nitpick comments (1)
backend/index.js (1)
7-7: Typo correction approved with a minor suggestion.The correction of the typo in the error middleware import is good. It fixes a potential bug in the application.
Consider removing the comment "// Corrected typo" as it might become outdated or unnecessary in the future. The correct spelling itself is sufficient.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
- backend/index.js (2 hunks)
- frontend/src/components/Shared/footer/Content.jsx (1 hunks)
🧰 Additional context used
🔇 Additional comments (4)
backend/index.js (1)
6-6: LGTM: Newsletter route successfully added.The addition of the newsletter route aligns with the PR objectives. The import statement and route middleware are correctly implemented, maintaining consistency with other routes in the application.
Also applies to: 22-22
frontend/src/components/Shared/footer/Content.jsx (3)
12-12: LGTM: NewsletterForm added to Content componentThe NewsletterForm component has been appropriately added to the Content component's return statement.
17-19: LGTM: NewsletterForm component declaration and state managementThe NewsletterForm component is correctly declared as a functional component, and useState is properly used for managing email and message states.
Line range hint
1-62: Overall assessment: Good implementation with room for improvementThe NewsletterForm component has been successfully added to the Content component, fulfilling the PR objective. The implementation is functional and generally well-structured. However, there are opportunities for improvement in the following areas:
- Error handling: Enhance the differentiation between network and server errors.
- Accessibility: Add proper labeling and ARIA attributes to form elements.
- Responsive design: Reconsider the absolute positioning of the form for better layout across different screen sizes.
These improvements will enhance the user experience, accessibility, and maintainability of the code. Overall, the changes are a good addition to the project, and with the suggested refinements, they will be even more robust and user-friendly.
|
@RamakrushnaBiswal please review and allow merge |
|
@meghanakn473 its not match with the UI and make alignment properly |
|
@meghanakn473 also resolve coderabit suggestions |
What kind of modifications do u want ? Can u please describe @RamakrushnaBiswal |
|
@meghanakn473 remove the background |
|
@RamakrushnaBiswal please check now |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RamakrushnaBiswal
added
level2
|
@meghanakn473 make it responsive |
|
@RamakrushnaBiswal done!! please check |
|
@meghanakn473 did you make it responsive |
|
@meghanakn473 |
…wsletter-form "Resolved merge conflicts"
|
@RamakrushnaBiswal |
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Outside diff range and nitpick comments (1)
frontend/src/components/Shared/footer/Content.jsx (1)
217-219: Optimize margin classesThe margin classes can be simplified. The
md:ml-4seems unnecessary since the parent flex container already handles spacing.- <div className="flex flex-col md:ml-4 mt-4 md:mt-0"> + <div className="flex flex-col mt-4 md:mt-0">
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
frontend/src/components/Shared/footer/Content.jsx (1)
23-71: Consider separating form logic from presentationTo improve maintainability and reusability, consider:
- Moving form submission logic to a custom hook (e.g.,
useNewsletterSubscription)- Creating a separate service for API calls
- Making the form component more generic and reusable
Example implementation:
// hooks/useNewsletterSubscription.js export const useNewsletterSubscription = () => { const [email, setEmail] = useState(''); const [message, setMessage] = useState(''); const subscribe = async (email) => { try { const response = await newsletterService.subscribe(email); // handle response } catch (error) { // handle error } }; return { email, setEmail, message, subscribe }; }; // services/newsletterService.js export const newsletterService = { subscribe: async (email) => { const response = await fetch('/api/subscribe', { method: 'POST', headers: { 'Content-Type': 'application/json' }, body: JSON.stringify({ email }) }); return response.json(); } };
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- frontend/src/components/Shared/footer/Content.jsx (5 hunks)
🔇 Additional comments (4)
frontend/src/components/Shared/footer/Content.jsx (4)
15-18: Remove duplicate NewsletterForm instanceThis implementation creates duplicate instances of NewsletterForm (here and in Nav component). This can lead to:
- Inconsistent state management
- Duplicate form submissions
- Maintenance challenges
The previous review comment suggesting consolidation of newsletter form instances is still valid. Please refer to that comment for the recommended solution.
27-47: Update API endpoint and enhance error handlingThe previous review comments about API endpoint correction and error handling enhancement are still valid. Please refer to those comments for the recommended solutions.
50-69: Improve form accessibility and responsive designThe previous review comments about form accessibility improvements and responsive styling are still valid. Please refer to those comments for the recommended solutions.
185-188: Reconsider newsletter form placementThe previous review comment about reconsidering newsletter form placement in mobile view is still valid. Please refer to that comment for the recommended solution.
meghanakn473
force-pushed
the
add-newsletter-form
branch
from
fb3a21e to
ebd95e9
Compare
There was a problem hiding this comment.
Actionable comments posted: 10
🧹 Outside diff range and nitpick comments (12)
backend/routes/eventRouter.js (1)
Line range hint
12-17: Update API documentation to include all endpoints.The endpoints list in the welcome response is incomplete. It should include all available routes, including the delete endpoint.
Update the endpoints object:
endpoints: { CreateEvent: "/event/create", GetEvents: "/event/all", + DeleteEvent: "/delete/:id", // After fixing the DELETE endpoint },backend/models/customer.model.js (2)
Line range hint
8-8: Add password field constraints and hashing requirement.The password field should have validation rules for minimum length, complexity requirements, and should be hashed before storage.
Apply this diff to enhance password security:
- password: String, + password: { + type: String, + required: true, + minlength: [8, 'Password must be at least 8 characters long'], + validate: { + validator: function(v) { + return /^(?=.*[A-Za-z])(?=.*\d)[A-Za-z\d]{8,}$/.test(v); + }, + message: 'Password must contain at least one letter and one number' + } + },
Line range hint
7-22: Add field constraints for better data integrity.Consider adding constraints for the name and bio fields to ensure data quality.
Apply these constraints:
- name: { type: String, required: true }, + name: { + type: String, + required: true, + trim: true, + minlength: [2, 'Name must be at least 2 characters long'], + maxlength: [50, 'Name cannot exceed 50 characters'] + }, - bio: String, + bio: { + type: String, + maxlength: [500, 'Bio cannot exceed 500 characters'], + trim: true + },backend/models/events.model.js (1)
Line range hint
35-42: Consider using a URL validation libraryThe current URL validation regex might miss edge cases or be too permissive. Consider using a dedicated URL validation library like
validator.js.image: { type: String, default: "https://imgur.com/4fSKUI4.jpg", validate: { - validator: function (v) { - return /^(https?:\/\/)?([\da-z\.-]+)\.([a-z\.]{2,6})([\/\w \.-]*)*\/?$/.test( - v, - ); - }, + validator: function (v) { + const validator = require('validator'); + return validator.isURL(v); + }, message: (props) => `${props.value} is not a valid URL!`, }, },backend/controller/event.controller.js (3)
Line range hint
29-46: Remove debug logging and improve error handling in deleteEvent.The
console.logstatement should be removed from production code. Also, consider adding more specific error handling for different scenarios.Apply these improvements:
const deleteEvent = async (req, res) => { try { const eventId = req.query.id; // Change to req.query.id - console.log(eventId); + if (!eventId) { + return res.status(400).json({ message: "Event ID is required" }); + } const event = await Event.findById(eventId); // Remove the object wrapper if (!event) { return res.status(404).json({ message: "Event not found" }); } await Event.findByIdAndDelete(eventId); res.status(200).json({ message: "Event deleted " }); } catch (error) { logger.error("Error deleting event:", error); + if (error.name === "CastError") { + return res.status(400).json({ message: "Invalid event ID format" }); + } res.status(500).json({ message: "Internal server error" }); } };
Line range hint
47-58: Consider returning an empty array instead of 204 status.The current implementation returns a 204 status code for empty results. While this is valid, returning an empty array with a 200 status is more common and might be easier for clients to handle.
Consider this change:
const getEvents = async (req, res) => { try { const events = await Event.find(); - - if (events.length === 0) { - return res.status(204).send(); // No Content - } - res.status(200).json(events); } catch (error) { logger.error("Error retrieving events:", error); res.status(500).json({ message: "Internal server error" }); } };
Line range hint
4-24: Consider adding pagination to createEvent endpoint.While the current implementation is correct, consider adding pagination support as the events collection grows. This would improve performance and reduce payload size.
Would you like me to provide an example implementation of pagination for the events endpoint?
CODE_OF_CONDUCT.md (4)
1-5: Consider using native markdown syntax for the header.While HTML alignment works, consider using markdown's native syntax for better maintainability:
-<div align="center"> - -# Code of Conduct - -</div> +<h1 align="center">Code of Conduct</h1>
24-24: Strengthen the language for clarity.Consider rephrasing to be more specific and impactful:
-Trolling, insulting or derogatory comments, and personal or political attacks +Deliberate intimidation, trolling, insulting/derogatory comments, and personal or political attacks🧰 Tools
🪛 LanguageTool
[style] ~24-~24: Try using a synonym here to strengthen your wording.
Context: ...ces - Trolling, insulting or derogatory comments, and personal or political attacks - Pu...(COMMENT_REMARK)
43-43: Add missing comma for better readability.-Project maintainers who do not follow or enforce the Code of Conduct in good faith may face temporary or permanent repercussions as determined by other members of the project's leadership. +Project maintainers who do not follow or enforce the Code of Conduct in good faith may face temporary or permanent repercussions, as determined by other members of the project's leadership.🧰 Tools
🪛 LanguageTool
[uncategorized] ~43-~43: Possible missing comma found.
Context: ...d faith may face temporary or permanent repercussions as determined by other members of the p...(AI_HYDRA_LEO_MISSING_COMMA)
49-53: Improve markdown formatting and grammar.
- Use proper markdown link syntax instead of bare URLs
- Add missing article "the" before "Community Impact Guidelines"
-This Code of Conduct is adapted from the [Contributor Covenant](https://www.contributor-covenant.org/version/2/1/code_of_conduct/), version 2.0, available at https://www.contributor-covenant.org/version/2/0/code_of_conduct.html. +This Code of Conduct is adapted from the [Contributor Covenant](https://www.contributor-covenant.org/version/2/1/code_of_conduct/), version 2.0, available at [https://www.contributor-covenant.org/version/2/0/code_of_conduct.html](https://www.contributor-covenant.org/version/2/0/code_of_conduct.html). -Community Impact Guidelines were inspired by Mozilla's code of conduct enforcement ladder. +The Community Impact Guidelines were inspired by Mozilla's code of conduct enforcement ladder. -For answers to common questions about this code of conduct, see the FAQ at https://www.contributor-covenant.org/faq. Translations are available at https://www.contributor-covenant.org/translations. +For answers to common questions about this code of conduct, see the [FAQ](https://www.contributor-covenant.org/faq). Translations are available at [https://www.contributor-covenant.org/translations](https://www.contributor-covenant.org/translations).🧰 Tools
🪛 LanguageTool
[uncategorized] ~50-~50: You might be missing the article “the” here.
Context: ....org/version/2/0/code_of_conduct.html. Community Impact Guidelines were inspired by Mozi...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
🪛 Markdownlint
49-49: null
Bare URL used(MD034, no-bare-urls)
53-53: null
Bare URL used(MD034, no-bare-urls)
53-53: null
Bare URL used(MD034, no-bare-urls)
README.md (1)
Line range hint
326-459: Replace hard tabs with spaces for consistent markdown rendering.The contributors table uses hard tabs for indentation which can cause inconsistent rendering across different markdown viewers.
Replace all hard tabs with spaces (typically 2 or 4 spaces) in the contributors table section. Here's an example for the first few lines:
- <tr> + <tr> - <td align="center"> + <td align="center">🧰 Tools
🪛 Markdownlint
414-414: Column: 1
Hard tabs(MD010, no-hard-tabs)
415-415: Column: 1
Hard tabs(MD010, no-hard-tabs)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (13)
- CODE_OF_CONDUCT.md (1 hunks)
- README.md (4 hunks)
- backend/controller/event.controller.js (1 hunks)
- backend/index.js (2 hunks)
- backend/models/customer.model.js (1 hunks)
- backend/models/events.model.js (1 hunks)
- backend/routes/eventRouter.js (1 hunks)
- frontend/package.json (1 hunks)
- frontend/src/components/Pages/HelpAndSupport.jsx (0 hunks)
- frontend/src/components/Pages/Login.jsx (2 hunks)
- frontend/src/components/Pages/Signup.jsx (3 hunks)
- frontend/src/components/Shared/footer/Content.jsx (4 hunks)
- frontend/src/router/index.jsx (0 hunks)
💤 Files with no reviewable changes (2)
- frontend/src/components/Pages/HelpAndSupport.jsx
- frontend/src/router/index.jsx
🚧 Files skipped from review as they are similar to previous changes (1)
- backend/index.js
🧰 Additional context used
🪛 LanguageTool
CODE_OF_CONDUCT.md
[style] ~24-~24: Try using a synonym here to strengthen your wording.
Context: ...ces - Trolling, insulting or derogatory comments, and personal or political attacks - Pu...(COMMENT_REMARK)
[uncategorized] ~43-~43: Possible missing comma found.
Context: ...d faith may face temporary or permanent repercussions as determined by other members of the p...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~50-~50: You might be missing the article “the” here.
Context: ....org/version/2/0/code_of_conduct.html. Community Impact Guidelines were inspired by Mozi...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
🪛 Markdownlint
CODE_OF_CONDUCT.md
49-49: null
Bare URL used(MD034, no-bare-urls)
53-53: null
Bare URL used(MD034, no-bare-urls)
53-53: null
Bare URL used(MD034, no-bare-urls)
README.md
326-326: Column: 1
Hard tabs(MD010, no-hard-tabs)
327-327: Column: 1
Hard tabs(MD010, no-hard-tabs)
370-370: Column: 1
Hard tabs(MD010, no-hard-tabs)
371-371: Column: 1
Hard tabs(MD010, no-hard-tabs)
414-414: Column: 1
Hard tabs(MD010, no-hard-tabs)
415-415: Column: 1
Hard tabs(MD010, no-hard-tabs)
458-458: Column: 1
Hard tabs(MD010, no-hard-tabs)
459-459: Column: 1
Hard tabs(MD010, no-hard-tabs)
🔇 Additional comments (11)
backend/models/customer.model.js (1)
Line range hint
1-33: Verify the impact of removingbookedEventsfield.The removal of the
bookedEventsfield from the schema could affect existing queries and data. This change appears to be part of a broader refactor removing event booking functionality.Let's verify the usage and ensure clean-up:
✅ Verification successful
Removal of
bookedEventsfield is part of an intentional revertThe git history shows that the removal of the
bookedEventsfield was part of a revert commit (d5e8550) that intentionally removed the event booking functionality. This revert also removed:
- The
bookEventandgetBookedEventscontroller functions- The corresponding routes and references
- The related field in the Event model (
bookedCustomers)The clean removal of all related code indicates this was an intentional architectural change, not an oversight.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for any remaining references to bookedEvents # Test 1: Check for any remaining references in controllers echo "Checking controllers for bookedEvents references..." rg -l 'bookedEvents' backend/controllers/ # Test 2: Check for any remaining references in routes echo "Checking routes for bookedEvents references..." rg -l 'bookedEvents' backend/routes/ # Test 3: Check for any API endpoints using populate with bookedEvents echo "Checking for populate usage with bookedEvents..." rg -l 'populate.*bookedEvents' backend/Length of output: 504
Script:
#!/bin/bash # Let's first check if the directory structure is different echo "Checking directory structure..." fd -t d backend # Now let's search for bookedEvents across all files echo "Searching for bookedEvents references..." rg -l "bookedEvents" # Let's also check for any mongoose references to events or bookings echo "Checking for event/booking related schemas..." rg -l "Schema.*event|booking" # Let's look at git history for the removed field echo "Checking git history for bookedEvents..." git log -p --all -S "bookedEvents"Length of output: 11167
backend/models/events.model.js (1)
Line range hint
9-52: Verify the complete removal of booking functionalityThe removal of the
bookedCustomersfield is part of a larger architectural change removing booking functionality. While the schema changes look correct, we should verify the complete cleanup across the codebase.Additionally, please confirm:
- Has the existing booking data been migrated or archived?
- Are there any frontend components that need to be updated?
- Has the API documentation been updated to reflect these changes?
✅ Verification successful
Booking functionality has been completely removed
Based on the comprehensive verification of the codebase:
- The event schema no longer contains any booking-related fields
- No booking-related routes exist in
eventRouter.jsorcustomerRouter.js- The customer model has been simplified without any booking references
- All other models (Admin, Feedback, Newsletter, Reservation) are also free of booking functionality
The cleanup appears to be thorough and complete across the backend codebase. The only remaining task would be to verify the frontend changes, but since we couldn't access those files in our verification, that would need manual verification.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify complete removal of booking-related code and references # Check for any remaining references to bookings in the codebase echo "Checking for remaining booking references..." rg -i "book(ed)?(_)?events?" --type js --type jsx --type ts --type tsx # Check for any API endpoints related to bookings echo "Checking for booking-related API endpoints..." rg -i "app\.(get|post|put|delete)\(.*book" backend/ # Check for any remaining references to the bookedCustomers field echo "Checking for bookedCustomers references..." rg -i "bookedCustomers" --type js --type jsx --type ts --type tsxLength of output: 543
Script:
#!/bin/bash # Let's try a different approach without file type restrictions echo "Checking for booking-related terms in all files..." rg -i "book(ed)?(_)?events?" echo -e "\nChecking for bookedCustomers field..." rg -i "bookedCustomers" echo -e "\nChecking for booking-related API routes..." rg -i "router\.(get|post|put|delete)\(.*book" backend/ echo -e "\nChecking for booking-related controller methods..." rg -i "book" backend/controllers/ echo -e "\nListing all route files to manually inspect..." fd "route" backend/Length of output: 998
Script:
#!/bin/bash # Let's check the content of relevant route files and search for any booking references echo "Checking content of route files..." cat backend/routes/eventRouter.js cat backend/routes/customerRouter.js echo -e "\nChecking for any booking references in models..." fd "model" backend/ --exec cat {} echo -e "\nChecking for any booking references in frontend components..." fd -e jsx -e js frontend/ --exec grep -i "book" {} || trueLength of output: 7118
frontend/package.json (2)
19-19: Please provide justification for the antd version downgrade.Downgrading from
^5.21.5to^5.21.2might reintroduce fixed bugs or cause compatibility issues. Could you explain the reason for this specific version change?Let's check the changelog between these versions:
#!/bin/bash # Description: Fetch package information to understand version differences # Get package details from npm echo "Checking antd package versions:" npm view [email protected] version description npm view [email protected] version description # Look for potential breaking changes or issues in commit history echo -e "\nChecking for related issues:" gh search issues "antd 5.21" --repo RamakrushnaBiswal/PlayCafe
19-19: Verify the impact of antd version downgrade.The downgrade from
^5.21.5to^5.21.2might affect components using antd, particularly the new newsletter form.Let's check for antd component usage and potential impacts:
✅ Verification successful
Let me try a different approach to verify the antd version downgrade impact.
Based on the results, I can now generate the final response:
The antd version downgrade appears safe to proceed
The codebase only uses the
messagecomponent from antd, which is a stable core component that hasn't had breaking changes between these patch versions (5.21.2 to 5.21.5). No newsletter-related files were found, and the existing antd usage is minimal and focused on basic functionality.
- All antd imports are limited to
messagecomponent in authentication-related pages- No complex component usage that might be affected by patch version differences
- No newsletter form implementation found that could be impacted
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check antd component usage in the newsletter form and related files # Search for antd imports and component usage echo "Checking antd component usage:" rg -l "from 'antd'" # Specifically check the newsletter form implementation echo -e "\nChecking newsletter form implementation:" rg -A 5 "NewsletterForm"Length of output: 438
Script:
#!/bin/bash # Search for antd imports and component usage in the frontend directory echo "Checking antd component usage in frontend:" rg -l "from 'antd'" frontend/ # Search for specific antd components with context echo -e "\nChecking antd component implementations:" rg -A 3 "import.*from 'antd'" frontend/ # Look for newsletter related files echo -e "\nChecking newsletter related files:" fd "newsletter" frontend/ -t fLength of output: 2489
backend/controller/event.controller.js (1)
70-70: LGTM: Export statement correctly reflects the available functions.The export statement has been updated to remove the booking-related functions while maintaining the core event management functionality.
Let's verify that the removed functions are not referenced elsewhere:
✅ Verification successful
Export changes are safe to proceed
The verification confirms that:
- The router only uses the currently exported functions:
createEvent,getEvents, anddeleteEvent- No other routers or files reference the removed booking-related functions
- The API endpoints documentation in the router matches the available functions
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for any remaining references to the removed booking functions rg -i "bookEvent|getBookedEvents"Length of output: 35
Script:
#!/bin/bash # Let's try a broader search to find any references to booking-related functionality # First, let's check for routes or API endpoints rg -i "book.*event|/book" -g "*.js" -g "*.ts" # Also search for any route definitions or controller imports rg -i "event.*controller|eventcontroller" -g "*.js" -g "*.ts" -A 3Length of output: 318
Script:
#!/bin/bash # Let's check the event router file to see what endpoints are defined cat backend/routes/eventRouter.js # Also check if there are any other routers that might be using these functions fd router.js --exec cat {}Length of output: 4765
frontend/src/components/Pages/Login.jsx (1)
Line range hint
29-39: Consider adding security measures.While the basic security measures are in place, consider enhancing security by:
- Adding CSRF protection to the login request
- Implementing rate limiting for failed login attempts
- Adding request timeout
frontend/src/components/Shared/footer/Content.jsx (3)
12-12: Skip comment - duplicate instance issue already reportedA previous review comment already addresses the duplicate NewsletterForm instance issue.
93-94: LGTM: Styling implementation is clean and maintainableThe template literal usage for conditional className assignment is well-implemented and follows React best practices.
211-213: Skip comment - positioning issues already reportedPrevious review comments already address the NewsletterForm positioning and responsive design improvements needed.
README.md (2)
Line range hint
327-458: LGTM: New contributor entries are well-formatted.The new contributor entries maintain consistent formatting with:
- Proper avatar image links
- Correct GitHub profile links
- Consistent image dimensions
- Well-formatted contributor names
🧰 Tools
🪛 Markdownlint
414-414: Column: 1
Hard tabs(MD010, no-hard-tabs)
415-415: Column: 1
Hard tabs(MD010, no-hard-tabs)
Line range hint
1-500: LGTM: Documentation structure and content.The overall documentation maintains high quality with:
- Clear project overview
- Well-organized sections
- Comprehensive contribution guidelines
- Proper licensing information
🧰 Tools
🪛 Markdownlint
414-414: Column: 1
Hard tabs(MD010, no-hard-tabs)
415-415: Column: 1
Hard tabs(MD010, no-hard-tabs)
I have added newsletter form in the footer section at the place u have asked me for,
This form helps users to subscribe and be updated with events.
@RamakrushnaBiswal please review and allow merge and assign the level 3, gssoc-extd, hacktoberfest labels
i hope ull conside it
Summary by CodeRabbit
New Features
NewsletterFormcomponent for user email input.Bug Fixes
These updates enhance user interaction with the newsletter service, improve application stability, and streamline the user experience by removing outdated features.