Fixed to pass script analyzer tests #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion 2.0 compatibilty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a number of different areas where I use PSSQLite I use script analyzer before things to go production. This was a problem because in a number of areas it would fail tests. I've adjusted almost all of the modules\scripts in the PSSQLite module so it will pass current script analyzer default tests. There were no major changes that would be noticeable in day-to-day use, however internally in Invoke-SqliteBulkCopy I had to rename New-SqliteBulkQuery to Invoke-SqliteBulkQuery in order to avoid having to add SupportsShouldProcess to CmdletBinding.
My previous submission failed AppVeyor tests because of how PS v2 requires SupportsShouldProcess=$true, but v3 and later does not. I fixed that in this version as well.