VolumeGroupReplication support #1287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ELENAGER
changed the title
ELENAGER
force-pushed
the
another_consistency_groups
branch
8 times, most recently
from
6c3d2b0 to
f92801b
Compare
ELENAGER
force-pushed
the
another_consistency_groups
branch
6 times, most recently
from
0fe0710 to
04b8580
Compare
ELENAGER
force-pushed
the
another_consistency_groups
branch
12 times, most recently
from
25c08da to
9f5f014
Compare
ELENAGER
force-pushed
the
another_consistency_groups
branch
3 times, most recently
from
52b2e50 to
6f0ea6f
Compare
ELENAGER
force-pushed
the
another_consistency_groups
branch
from
6f0ea6f to
cab4559
Compare
ELENAGER
changed the title
ELENAGER
force-pushed
the
another_consistency_groups
branch
from
de5467e to
820ec01
Compare
ELENAGER
force-pushed
the
another_consistency_groups
branch
from
820ec01 to
7c49a30
Compare
youhangwang
reviewed
May 15, 2024
| Spec: volgroup.VolumeGroupReplicationSpec{ | ||
| ReplicationState: state, | ||
| VolumeGroupReplicationClass: volumeReplicationClass.GetName(), | ||
| Selector: &v.instance.Spec.PVCSelector, |
There was a problem hiding this comment.
In RBD consistency group, the same pvc selector is used in VolumeGroupReplication with the VolumeReplicationGroup, which means, if CG is enabled, all the pvcs in a VRG should be in a single consistency group?
youhangwang
reviewed
May 15, 2024
| func (v *VRGInstance) createVR(vrNamespacedName types.NamespacedName, state volrep.ReplicationState) error { | ||
| volumeReplicationClass, err := v.selectVolumeReplicationClass(vrNamespacedName) | ||
| func (v *VRGInstance) createVR(pvc *corev1.PersistentVolumeClaim, state volrep.ReplicationState) error { | ||
| volumeReplicationClass, err := v.selectVolumeReplicationClass(pvc) |
There was a problem hiding this comment.
If an application contains multiple PVCs with different StorageClass/Provisioner(these PVCs contains a same label that match the VRG label selector). Ramen will create a replicationgroupreplication with a label selector to select all these pvcs, but they have different storage class, will this be a problem for the replicationgroupreplication?
ELENAGER
force-pushed
the
another_consistency_groups
branch
from
7c49a30 to
aed7f44
Compare
ELENAGER
force-pushed
the
another_consistency_groups
branch
3 times, most recently
from
995d046 to
f52f239
Compare
ELENAGER
force-pushed
the
another_consistency_groups
branch
from
f52f239 to
0faca36
Compare
Signed-off-by: Elena Gershkovich <[email protected]>
Signed-off-by: Elena Gershkovich <[email protected]>
Signed-off-by: Elena Gershkovich <[email protected]>
ELENAGER
force-pushed
the
another_consistency_groups
branch
from
0faca36 to
e3c28d7
Compare
Rakshith-R
reviewed
Jul 9, 2024
Comment on lines
+740
to
+759
| func (v *VRGInstance) updateGroupReplicationClassList() error { | ||
| labelSelector := v.instance.Spec.Async.ReplicationClassSelector | ||
|
|
||
| v.log.Info("Fetching VolumeGroupReplicationClass", "labeled", labels.Set(labelSelector.MatchLabels)) | ||
| listOptions := []client.ListOption{ | ||
| client.MatchingLabels(labelSelector.MatchLabels), | ||
| } | ||
|
|
||
| if err := v.reconciler.List(v.ctx, v.grpReplClassList, listOptions...); err != nil { | ||
| v.log.Error(err, "Failed to list Group Replication Classes", | ||
| "labeled", labels.Set(labelSelector.MatchLabels)) | ||
|
|
||
| return fmt.Errorf("failed to list Group Replication Classes, %w", err) | ||
| } | ||
|
|
||
| v.log.Info("Number of Group Replication Classes", "count", len(v.grpReplClassList.Items)) | ||
|
|
||
| return nil | ||
| } | ||
|
|
There was a problem hiding this comment.
@ELENAGER
Can you please match this update function with the changes coming from https://github.com/RamenDR/ramen/pull/1476/files#diff-a3c633f01e052ce1a42ea903ff76debacd956585919969d1f164ff88a7028f44 ?
and are we sure we should be using the same replicationClassSelector varibale for groupReplicationClass too or have a separate groupReplicationClassSelector ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative VolumeGroupReplication support