Caching Rook addons resources #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirs
reviewed
Apr 30, 2024
test/addons/rook-cluster/fetch
Outdated
| from drenv import cache | ||
|
|
||
| os.chdir(os.path.dirname(__file__)) | ||
| path = cache.path("addons/cluster-test.yaml") |
There was a problem hiding this comment.
This is the cache of the rook-cluster addon, so we should name it "addons/rook-cluster.yaml"
abhijeet219
changed the title
nirs
reviewed
May 1, 2024
|
@abhijeet219 Also update the pr message:
|
|
Tested using #1359 |
Added and explained |
@abhijeet219 yes, the current example are long and not clear and better remove. Describing how fetch works is not needed in this PR - it was needed only in the PR introducing the cache. |
Currently the addons fetch kustomization resources whenever they are started. This change will start using cache for those resources, so starting an addon can directly use the cached resources. Changes: - drenv fetch can be used to fetch resources anytime. - Starting an addon will first try to fetch resources, then apply the fetched resources. If there is no change, fetch won't do anything, so takes very less time. Signed-off-by: Abhijeet Shakya <[email protected]>
nirs
approved these changes
May 2, 2024
This was referenced May 2, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the addons fetch kustomization resources whenever they are started.
This change will start using cache for those resources, so starting an addon can directly use the cached resources.
Changes:
Example demonstrating how the cache works:
Fetching of resources for envs/regional-dr.yaml:
Fetching resources may take different amount of time for different runs. And once fetched, addons can directly use these resources to get started, saving time and escaping the flaky network situation.