Delete manifestwork for application namespace #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirs
reviewed
May 8, 2024
abhijeet219
force-pushed
the
mw-namespace
branch
3 times, most recently
from
43b930d to
e357612
Compare
ShyamsundarR
reviewed
May 9, 2024
ShyamsundarR
reviewed
May 9, 2024
abhijeet219
force-pushed
the
mw-namespace
branch
2 times, most recently
from
721c578 to
c1e5699
Compare
abhijeet219
force-pushed
the
mw-namespace
branch
4 times, most recently
from
4154453 to
e634d18
Compare
abhijeet219
force-pushed
the
mw-namespace
branch
2 times, most recently
from
c4bc3bc to
dda721a
Compare
abhijeet219
force-pushed
the
mw-namespace
branch
5 times, most recently
from
29ed404 to
b8735a2
Compare
abhijeet219
force-pushed
the
mw-namespace
branch
4 times, most recently
from
f0bdf1b to
4ea8d31
Compare
abhijeet219
force-pushed
the
mw-namespace
branch
3 times, most recently
from
f2ca445 to
776428d
Compare
ShyamsundarR
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
@abhijeet219 please rebase to latest main, and we can merge. Change looks good.
The one nit I have is on the function name, if that can be addressed as part of the rebase it would be nice. Thanks!
Signed-off-by: Abhijeet Shakya <[email protected]>
The changeset includes a new DeleteNamespaceManifestWork() func, which first checks if the mw.Spec has delete option or if it already has a DeletionTimestamp. Accordingly, it proceeds to delete the namespace manifestwork. It also updates the namespace manifestwork with the deleteOption and propogationPolicy of type orphan, whenever the createOrUpdateNamespaceManifest() func is called. Fixes: [Bug 2059669](https://bugzilla.redhat.com/show_bug.cgi?id=2059669) Signed-off-by: Abhijeet Shakya <[email protected]>
abhijeet219
force-pushed
the
mw-namespace
branch
from
776428d to
167d2e9
Compare
Signed-off-by: Abhijeet Shakya <[email protected]>
abhijeet219
force-pushed
the
mw-namespace
branch
from
167d2e9 to
68e95c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
The changeset includes a new DeleteNamespaceManifestWork() func to delete the manifestwork for namespace. It first checks if the mw.Spec has delete option or if it already has a DeletionTimestamp. Accordingly, it proceeds to delete the
namespace manifestwork.
Also introduces updating of the namespace manifestwork with the deleteOption and propogationPolicy of type orphan, whenever the createOrUpdateNamespaceManifest() func is called.
Fixes: Bug 2059669