Install argocd #1421
Merged
Install argocd #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
par97
force-pushed
the
install-argocd
branch
2 times, most recently
from
1f636a5 to
ae586b9
Compare
nirs
reviewed
May 28, 2024
nirs
reviewed
May 29, 2024
nirs
reviewed
Jun 9, 2024
nirs
reviewed
Jun 9, 2024
nirs
reviewed
Jun 9, 2024
nirs
force-pushed
the
install-argocd
branch
2 times, most recently
from
8c2bbce to
5bda9f0
Compare
nirs
reviewed
Jun 9, 2024
par97
force-pushed
the
install-argocd
branch
3 times, most recently
from
9203b27 to
4ae91e1
Compare
nirs
reviewed
Jun 18, 2024
nirs
reviewed
Jun 19, 2024
Signed-off-by: jacklu <[email protected]>
nirs
approved these changes
Jun 19, 2024
Local test with argocd env |
Local test with regional-dr env |
BenamarMk
approved these changes
Jun 19, 2024
nirs
added a commit
to nirs/ramen
that referenced
this pull request
Jun 20, 2024
We change the cache API in RamenDR#1389 but it was merge after the argocd was added. - Use cache.get() instead of removed cache.fetch() - Change current directory for start hook was missing in RamenDR#1421, not sure how the cache worked without it. Signed-off-by: Nir Soffer <[email protected]>
ShyamsundarR
pushed a commit
that referenced
this pull request
Jun 20, 2024
We change the cache API in #1389 but it was merge after the argocd was added. - Use cache.get() instead of removed cache.fetch() - Change current directory for start hook was missing in #1421, not sure how the cache worked without it. Signed-off-by: Nir Soffer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR installs argocd operator on hub cluster, and enables ability to create argocd application CR and applicationset CR on hub, and the application could be auto deployed to the target dr cluster by argocd controller, using push mode.