Upgrade ramen to latest snapshotter crd and enforce VGS name length limit #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenamarMk
force-pushed
the
upgrade-ramen-to-latest-snapshotter-crd
branch
from
a3756dd to
c83cf3f
Compare
BenamarMk
changed the title
added 3 commits
September 14, 2024 04:48
- Integrated the latest CRD from external-snapshotter. - Updated dependencies and relevant configuration files. - Changed VolumeSnapshotRefList in VolumeGroupSnapshotStatus to PVCVolumeSnapshotRefList, which allows to map a VolumeSnapshot to the application PVC. Signed-off-by: Benamar Mekhissi <[email protected]>
Signed-off-by: Benamar Mekhissi <[email protected]>
This is mainly to ensure that the VRG on the primary and secondary are in sync in regards to labels and annotations Signed-off-by: Benamar Mekhissi <[email protected]>
BenamarMk
force-pushed
the
upgrade-ramen-to-latest-snapshotter-crd
branch
from
54520e5 to
24650ae
Compare
ELENAGER
reviewed
Sep 16, 2024
| @@ -92,4 +91,4 @@ spec: | |||
| type: object | |||
| served: true | |||
| storage: true | |||
| subresources: {} | |||
There was a problem hiding this comment.
@BenamarMk , this file is not actually changed?
There was a problem hiding this comment.
Ok, thanks. I'll remove it.
ELENAGER
reviewed
Sep 16, 2024
| @@ -285,13 +292,13 @@ func (h *volumeGroupSourceHandler) RestoreVolumesFromSnapshot( | |||
|
|
|||
| volumeSnapshot := &vsv1.VolumeSnapshot{} | |||
| if err := h.Client.Get(ctx, | |||
| types.NamespacedName{Name: vsRef.Name, Namespace: vsRef.Namespace}, | |||
| types.NamespacedName{Name: vsName, Namespace: pvc.Namespace}, | |||
There was a problem hiding this comment.
Maybe it's better to look for volume snapshot by vs name and vs namespace? What if one day vs namespace will be different from pvc namespace?
There was a problem hiding this comment.
The VolumeGroupSnapshot status looks like this:
status:
boundVolumeGroupSnapshotContentName: groupsnapcontent-66e442b9-d739-48cc-9158-a6472c3a2022
creationTime: "2024-09-13T13:05:00Z"
pvcVolumeSnapshotRefList:
- persistentVolumeClaimRef:
name: busybox-cg2-pvc1
volumeSnapshotRef:
name: snapshot-bc3b0f7a8da345fd3d423eebe43cf6023ad34b03d7ff1df3fdf227da330303e6-2024-09-13-1.5.0
- persistentVolumeClaimRef:
name: busybox-cg2-pvc2
volumeSnapshotRef:
name: snapshot-811a028ea7008016c74c082430686955ae178d56cc4f0fdc3e5394da2cc20a1f-2024-09-13-1.5.3
readyToUse: true
We have only the names in the status. The snapshot is for the PVC and we already have the PVC for it. Therefore we use the PVC namespace. The PVC namespace is the same as the VolumeGroupSnapshot.
ELENAGER
approved these changes
Sep 16, 2024
ShyamsundarR
approved these changes
Sep 16, 2024
|
LGTM, requeued the unit test run before merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following updates:
VolumeSnapshotRefListinVolumeGroupSnapshotStatustoPVCVolumeSnapshotRefList, which allows to map aVolumeSnapshotto the applicationPVC.Fixes: 2311790