Add missing space in error #1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix 4 instances of missing space:
belonging toVolumeReplicationGroup
Signed-off-by: Nir Soffer <[email protected]>
BenamarMk
approved these changes
Jan 27, 2025
nirs
commented
Jan 27, 2025
| @@ -1918,7 +1918,7 @@ func (v *VRGInstance) addProtectedAnnotationForPVC(pvc *corev1.PersistentVolumeC | |||
| // v.updateProtectedPVCCondition(pvc.Name, PVCError, msg) | |||
| log.Error(err, "Failed to update PersistentVolumeClaim annotation") | |||
|
|
|||
| return fmt.Errorf("failed to update PersistentVolumeClaim (%s/%s) annotation (%s) belonging to"+ | |||
| return fmt.Errorf("failed to update PersistentVolumeClaim (%s/%s) annotation (%s) belonging to "+ | |||
There was a problem hiding this comment.
Turns out this log has
{"VolumeReplicationGroup": {"name":"appset-deploy-rbd-busybox","namespace":"e2e-appset-deploy-rbd-busybox"}, "rid": "93ab4d6f-3f56-402c-ba11-90c7793ee00e", "State": "primary"}
So we can remove the "belonging to VolumeReplicationGroup (%s/%s)" part instead of fixing it.
There was a problem hiding this comment.
But the log does not help since this error is logged from another logger that does not have the vrg info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 4 instances of missing space: