Update the comment and Add a check (apache#9571)

* Update the comment and Add a check

Update the comment on TableProvider::supports_filters_pushdown() to say that the returned vector much have the same size as the filters argument.
Add a check at the callsite that the vec returned from supports_filters_pushdown is the same size as the filters passed:

* update after the review

* Update push_down_filter.rs

datafusion/core/src/datasource/provider.rs

@@ -166,6 +166,7 @@ pub trait TableProvider: Sync + Send {
 
     /// Tests whether the table provider can make use of any or all filter expressions
     /// to optimise data retrieval.
+    /// Note:  the returned vector much have the same size as the filters argument.
     #[allow(deprecated)]
     fn supports_filters_pushdown(
         &self,

datafusion/optimizer/src/push_down_filter.rs

@@ -859,6 +859,13 @@ impl OptimizerRule for PushDownFilter {
                 let results = scan
                     .source
                     .supports_filters_pushdown(filter_predicates.as_slice())?;
+                if filter_predicates.len() != results.len() {
+                    return internal_err!(
+                        "Vec returned length: {} from supports_filters_pushdown is not the same size as the filters passed, which length is: {}",
+                        results.len(),
+                        filter_predicates.len());
+                }
+
                 let zip = filter_predicates.iter().zip(results);
 
                 let new_scan_filters = zip