Ato 2960 update bot with persist slot config (#64)

* update rasa-pro * swap property `reset_after_flow_ends` for `persist_slots` * update e2e test cases * update verify account flow to persist a slot filled in a set_slots step
RasaHQ · Nov 29, 2024 · ba57f87 · ba57f87
1 parent 2eb722d
commit ba57f87
Show file tree

Hide file tree

Showing 7 changed files with 801 additions and 568 deletions.
diff --git a/data/flows/verify_account.yml b/data/flows/verify_account.yml
@@ -6,15 +6,19 @@ flows:
       - intent:
           name: verify_account
           confidence_threshold: 0.9
+    persisted_slots:
+      - based_in_california
+      - based_in_the_us
     steps:
       - collect: verify_account_email
         ask_before_filling: true
       - collect: based_in_california
         ask_before_filling: false
-        reset_after_flow_ends: false
         next:
           - if: slots.based_in_california
             then:
+              - set_slots:
+                 - based_in_the_us: true
               - collect: verify_account_sufficient_california_income
                 ask_before_filling: true
                 next:

diff --git a/domain/flows/verify_account.yml b/domain/flows/verify_account.yml
@@ -13,6 +13,11 @@ slots:
     shared_for_coexistence: True
     mappings:
       - type: from_llm
+  based_in_the_us:
+    type: bool
+    shared_for_coexistence: True
+    mappings:
+      - type: from_llm
   verify_account_sufficient_california_income:
     type: bool
     mappings:

diff --git a/e2e_tests/passing/happy_path/user_verifies_account.yml b/e2e_tests/passing/happy_path/user_verifies_account.yml
@@ -17,6 +17,15 @@ test_cases:
       - slot_was_set: 
         - verify_account_confirmation: true
       - utter: utter_verify_account_success
+      # verify slot reset
+      - slot_was_set: 
+        - verify_account_email: null
+        - verify_account_confirmation: null
+        - verify_account_sufficient_california_income: null
+      # verify slot persistence
+      - slot_was_not_set:
+        - based_in_california
+        - based_in_the_us
 
   - test_case: Verify account for California resident with insufficient income
     steps:
@@ -36,6 +45,15 @@ test_cases:
       - slot_was_set:
         - verify_account_sufficient_california_income: false
       - utter: utter_ca_income_insufficient
+      # verify slot reset
+      - slot_was_set: 
+        - verify_account_email: null
+        - verify_account_confirmation: null
+        - verify_account_sufficient_california_income: null
+      # verify slot persistence
+      - slot_was_not_set:
+        - based_in_california
+        - based_in_the_us
       - utter: utter_can_do_something_else
 
   - test_case: Verify account for California resident with sufficient income
@@ -60,4 +78,13 @@ test_cases:
       - slot_was_set:
         - verify_account_confirmation: true
       - utter: utter_verify_account_success
-      - utter: utter_can_do_something_else
+      # verify slot reset
+      - slot_was_set: 
+        - verify_account_email: null
+        - verify_account_confirmation: null
+        - verify_account_sufficient_california_income: null
+      # verify slot persistence
+      - slot_was_not_set:
+        - based_in_california
+        - based_in_the_us
+      - utter: utter_can_do_something_else
diff --git a/e2e_tests_with_assertions/passing/happy_path/user_orders_pizza.yml b/e2e_tests_with_assertions/passing/happy_path/user_orders_pizza.yml
@@ -48,6 +48,23 @@ test_cases:
                   value: 1234 5678 9012 3456
             - bot_uttered:
                 utter_name: utter_execute_payment
+            - flow_completed:
+                flow_id: order_pizza
+            # verify slot reset
+            - slot_was_set:
+                - name: pizza
+                  value: null
+                - name: num_pizza
+                  value: null
+                - name: address
+                  value: null
+                - name: card_details
+                  value: null
+                - name: payment_option
+                  value: null
+            # verify slot persistence
+            - slot_was_not_set:
+                - name: confirmation_order
 
   - test_case: user_orders_pizza_stating_which_type_and_pays_with_points
     steps:
@@ -117,4 +134,23 @@ test_cases:
                 utter_name: utter_execute_payment
             - flow_completed:
                 flow_id: order_pizza
+            # verify slot reset
+            - slot_was_set:
+                - name: pizza
+                  value: null
+                - name: num_pizza
+                  value: null
+                - name: address
+                  value: null
+                - name: card_details
+                  value: null
+                - name: payment_option
+                  value: null
+                - name: user_name
+                  value: null
+                - name: user_password
+                  value: null
+            # verify slot persistence
+            - slot_was_not_set:
+                - name: confirmation_order
 
diff --git a/e2e_tests_with_assertions/passing/happy_path/user_verifies_account.yml b/e2e_tests_with_assertions/passing/happy_path/user_verifies_account.yml
@@ -36,6 +36,18 @@ test_cases:
                 value: true
           - bot_uttered:
               utter_name: utter_verify_account_success
+          # verify slot reset
+          - slot_was_set:
+              - name: verify_account_email
+                value: null
+              - name: verify_account_confirmation
+                value: null
+              - name: verify_account_sufficient_california_income
+                value: null
+          # verify slot persistence
+          - slot_was_not_set:
+            - name: based_in_california
+            - name: based_in_the_us
 
   - test_case: Verify account for California resident with insufficient income
     steps:
@@ -57,6 +69,8 @@ test_cases:
           - slot_was_set:
               - name: based_in_california
                 value: true
+              - name: based_in_the_us
+                value: true
           - bot_uttered:
               utter_name: utter_ask_verify_account_sufficient_california_income
       - user: "no"
@@ -66,6 +80,18 @@ test_cases:
                 value: false
           - bot_uttered:
               utter_name: utter_ca_income_insufficient
+          # verify slot reset
+          - slot_was_set:
+              - name: verify_account_email
+                value: null
+              - name: verify_account_confirmation
+                value: null
+              - name: verify_account_sufficient_california_income
+                value: null
+          # verify slot persistence
+          - slot_was_not_set:
+            - name: based_in_california
+            - name: based_in_the_us
           - bot_uttered:
               utter_name: utter_can_do_something_else
 
@@ -90,6 +116,8 @@ test_cases:
             - slot_was_set:
                 - name: based_in_california
                   value: true
+                - name: based_in_the_us
+                  value: true
             - bot_uttered:
                 utter_name: utter_ask_verify_account_sufficient_california_income
       - user: "yes"
@@ -108,5 +136,17 @@ test_cases:
                 value: true
           - bot_uttered:
                 utter_name: utter_verify_account_success
+          # verify slot reset
+          - slot_was_set:
+              - name: verify_account_email
+                value: null
+              - name: verify_account_confirmation
+                value: null
+              - name: verify_account_sufficient_california_income
+                value: null
+          # verify slot persistence
+          - slot_was_not_set:
+            - name: based_in_california
+            - name: based_in_the_us
           - bot_uttered:
               utter_name: utter_can_do_something_else