Improved tests #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabergma
requested changes
Feb 14, 2024
e2e_tests/passing/happy_path/user_books_a_restaurant_with_an_alternative_time.yml
Show resolved
Hide resolved
e2e_tests/passing/happy_path/user_books_a_restaurant_with_their_own_alternative.yml
Show resolved
Hide resolved
|
Is your branch up to date? Seems like the actions were not executed successfully. There are some recent changes for that on main. |
|
Ok seems there's one flaky test left and then the negation test needs the new clarify option sorting |
|
should we wait for the next rasa release and then update the rasa version? and should we move the flaky test maybe to a folder could "flaky"? |
tabergma
approved these changes
Mar 6, 2024
Co-authored-by: Tanja <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can be merged after clarify command is fixed in rasa