-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ATO-1652] Add target to check if gRPC code is in sync with generated python code #1111
Merged
radovanZRasa
merged 1 commit into
main
from
ci/ATO-1652-check-for-proto-python-discrepancy
Jun 19, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,6 +20,10 @@ install: | |
poetry run python -m pip install -U pip | ||
poetry install | ||
|
||
install-dev: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Target to install runtime and dev dependencies. |
||
poetry run python -m pip install -U pip | ||
poetry install --with dev | ||
|
||
clean: | ||
find . -name '*.pyc' -exec rm -f {} + | ||
find . -name '*.pyo' -exec rm -f {} + | ||
|
@@ -38,6 +42,7 @@ lint: | |
poetry run ruff check rasa_sdk tests --ignore D | ||
poetry run black --exclude="rasa_sdk/grpc_py" --check rasa_sdk tests | ||
make lint-docstrings | ||
make check-generate-grpc-code-in-sync | ||
|
||
# Compare against `main` if no branch was provided | ||
BRANCH ?= main | ||
|
@@ -62,10 +67,15 @@ release: | |
poetry run python scripts/release.py | ||
|
||
generate-grpc: | ||
python -m grpc_tools.protoc \ | ||
poetry run python -m grpc_tools.protoc \ | ||
-Irasa_sdk/grpc_py=./proto \ | ||
--python_out=. \ | ||
--grpc_python_out=. \ | ||
--pyi_out=. \ | ||
proto/action_webhook.proto \ | ||
proto/health.proto | ||
|
||
check-generate-grpc-code-in-sync: generate-grpc | ||
# this is a helper to check if the generated code is in sync with the proto files | ||
# it's not run on CI at the moment | ||
git diff --exit-code rasa_sdk/grpc_py | if [ "$$(wc -c)" -eq 0 ]; then echo "Generated code is in sync with proto files"; else echo "Generated code is not in sync with proto files"; exit 1; fi |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this to help with debugging.