Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade opentelemetry-sdk and opentelemetry-api to 1.16.0 #1115

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

aleksandarmijat
Copy link
Contributor

Proposed changes:

  • Initializing tracing in rasa-pro uses opentelemetry-sdk which resets all warning filters making our warning filters ineffective. This behavior has been upgraded in 1.16.0 version.

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation in the rasaHQ/rasa
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@aleksandarmijat aleksandarmijat requested a review from ancalita June 27, 2024 10:32
@aleksandarmijat
Copy link
Contributor Author

@ancalita Do you think we should have a changelog for this change? If yes, would it be misc?

Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aleksandarmijat Up to you if you want to add misc changelog, we don't usually add them for housekeeping upgrades, only when fixing vulnerabilities because that's when it's of interest to those downloading the package.

@aleksandarmijat
Copy link
Contributor Author

@aleksandarmijat Up to you if you want to add misc changelog, we don't usually add them for housekeeping upgrades, only when fixing vulnerabilities because that's when it's of interest to those downloading the package.

I see, thanks Anca for the explanation, much appreciated!

@aleksandarmijat aleksandarmijat merged commit f73a39e into main Jun 27, 2024
16 checks passed
@aleksandarmijat aleksandarmijat deleted the ATO-2563-upgrade-opentelemetry branch June 27, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants