-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ATO-2609] Add gRPC tracing #1117
Conversation
b41e9ad
to
9a135b4
Compare
9a135b4
to
308eadd
Compare
@radovanZRasa We should do a quick check that this works with grpc as well. |
@radovanZRasa Do we know what are the errors in the screenshot you shared in the PR description? Referring to the spans with exclamation mark next to them. |
Yea, I was testing Rasa with CALM bot from |
It's most likely the |
They will also appear in this case. Good thing is that all calls are logged so everything is there. As image shows all calls are recorded. |
I added custom action AddContact and added tracing into it: from typing import Any, Dict
from rasa_sdk import Action, Tracker
from rasa_sdk.events import SlotSet
from rasa_sdk.executor import CollectingDispatcher
from rasa_sdk.tracing.tracer_register import ActionExecutorTracerRegister
class AddContact(Action):
def name(self) -> str:
return "add_contact"
def run(
self, dispatcher: CollectingDispatcher, tracker: Tracker, domain: Dict[str, Any]
):
tracer = ActionExecutorTracerRegister().get_tracer()
with tracer.start_as_current_span("AddContact.add_contact"):
return [SlotSet("return_value", "success")] |
…between Rasa and custom action server
c8c92fb
to
03dd122
Compare
Add tracing between Rasa and action server.
Status (please check what you already did):
black
(please check Readme for instructions)