Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly filter out Sanic warnings after Sanic is initialized #1120

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

aleksandarmijat
Copy link
Contributor

Proposed changes:

  • Explicitly filter out Sanic warnings after Sanic is initialized

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation in the rasaHQ/rasa
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@aleksandarmijat aleksandarmijat requested a review from ancalita July 3, 2024 10:47
@aleksandarmijat aleksandarmijat self-assigned this Jul 3, 2024
@Tawakalt
Copy link
Contributor

Tawakalt commented Jul 3, 2024

Do we need a changelog?

@radovanZRasa
Copy link
Contributor

We should at list have a misc changelog.

changelog/1120.misc.md Outdated Show resolved Hide resolved
Co-authored-by: OLANIYI TAWAKALT <[email protected]>
@aleksandarmijat aleksandarmijat requested a review from Tawakalt July 3, 2024 11:10
@aleksandarmijat aleksandarmijat merged commit 3c6a5f4 into main Jul 3, 2024
16 checks passed
@aleksandarmijat aleksandarmijat deleted the explicitly-filter-sanic-warnings branch July 3, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants