Add option to specify --fixed-model-name
#24
+22
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Until this PR is approved, this version of the github action can be used by referencing |
|
Besides that PR are ignored here: this is a nice feature ! Hopefully somebody can jump in to comment of the future of this repository |
lumpidu
reviewed
Feb 3, 2023
| @@ -302,6 +311,15 @@ runs: | |||
| OUTPUT="${OUTPUT}\n$(python3 ${{ github.action_path }}/scripts/cross_validation_results.py)" | |||
| fi | |||
|
|
|||
| if [[ -f "${{ inputs.workspace }}/${{ inputs.result_directory }}/failed_test_stories.yml" ]]; then | |||
There was a problem hiding this comment.
You probably based this PR on your other PR. These should be applicable separately.
lumpidu
reviewed
Feb 3, 2023
| @@ -51,6 +51,7 @@ def entity_table(): | |||
| cols = ["support", "f1-score", "precision", "recall"] | |||
| writer.headers = ["entity"] + cols | |||
|
|
|||
| data.pop("accuracy", None) | |||
|
Agree with @lumpidu, if you can remove those two blocks from this PR then it will be good to go. |
|
Yes, the other PR should be reviewed and merged first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements issue #23.