Output cluster metadata in separate file #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobnissen
added
the
DO NOT SQUASH
12 tasks
jakobnissen
force-pushed
the
cluster_info
branch
from
51c5e8e to
8426cc8
Compare
jakobnissen
force-pushed
the
binsplit
branch
from
4dbf5ac to
78da424
Compare
jakobnissen
force-pushed
the
cluster_info
branch
from
8426cc8 to
81e90a4
Compare
jakobnissen
force-pushed
the
cluster_info
branch
from
81e90a4 to
44ef320
Compare
Each Cluster object now also stores the actual observed peak/valley ratio for the given cluster, where it previously only stored the maximally allows PVR. This metadata can be valuable, as clusters with low PVR are usually of higher quality.
This file contains information about the clusters, which can be useful for users, especially in determining which contigs might be good or bad.
jakobnissen
force-pushed
the
cluster_info
branch
from
44ef320 to
ad42dbf
Compare
jakobnissen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overall idea here is that we output more metadata about generated clusters, allowing our users to more easily get an idea of the cluster quality.
I would like to ping off ideas around this with you guys.
See #240
Based on #251, though the changes are small enough that they can be cherry-picked to existing master if necessary