Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use setuptools-scm for Vamb versioning #274

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Use setuptools-scm for Vamb versioning #274

merged 1 commit into from
Nov 27, 2023

Conversation

jakobnissen
Copy link
Member

This tool will automatically set the correct Vamb version based on Git info. This is useful for several reasons:

  • It makes it harder for us to mess up the versions on release
  • When testing Vamb, the log file will tell us the exact commit used

Not 100% sure we really want this

@jakobnissen jakobnissen marked this pull request as ready for review November 27, 2023 09:31
@jakobnissen jakobnissen force-pushed the scm branch 3 times, most recently from 9054689 to a5d947d Compare November 27, 2023 09:39
This tool will automatically set the correct Vamb version based on Git info.
This is useful for several reasons:
* It makes it harder for us to mess up the versions on release
* When testing Vamb, the log file will tell us the exact commit used
@jakobnissen
Copy link
Member Author

I'm going to merge this and give it a go, so we get some experience with it. We'll revert it before v5 if it causes problems.

@jakobnissen jakobnissen merged commit 5f2cd70 into master Nov 27, 2023
@jakobnissen jakobnissen deleted the scm branch February 28, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant