Use the correct binsplitter in TaxVamb #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, TaxVamb incorrectly used the inert splitter instead of the one specified on command-line, when loading its composition. Since the binsplitter is properly initialized in `calc_tnf`, such that it will not attempt to binsplit on 'C' if this separator is not present, the use of an inert splitter skipped this initialization. This caused a bug where the lack of a separator was not detected until the data was clustered, far too late.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, TaxVamb incorrectly used the inert splitter instead of the one specified on command-line, when loading its composition. Since the binsplitter is properly initialized in
calc_tnf, such that it will not attempt to binsplit on 'C' if this separator is not present, the use of an inert splitter skipped this initialization.This caused a bug where the lack of a separator was not detected until the data was clustered, far too late.