Skip to content

Updating RVN Mobile Wallet Links.md #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CryptoLifeCrisis
Copy link

Changing two inactive links away from the long-depreciated Mobile RVN Wallet, to the current Magic Wallet App Store links.

Changing two inactive links away from the long-depreciated Mobile RVN Wallet, to the current Magic Wallet App Store links.
Copy link

@corviato1 corviato1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the correct location for this change.

Go to:
https://github.com/CryptoLifeCrisis/ravenproject.github.io/blob/patch-1/_data/wallets.yml

Add the code:

  • name: Magic Wallet
    logo: /assets/img/pages/wallet/magic-wallet.png
    url: https://x.com/magicwalletapp/
    asset-support: true
    platforms:
    • app-store-badge
    • google-play-badge

Then

Go to: https://github.com/CryptoLifeCrisis/ravenproject.github.io/tree/patch-1/assets/img/pages/wallet

Add the image.

Then

Cancel this merge, and make a new merge.

magic-wallet

@CryptoLifeCrisis
Copy link
Author

This is not the correct location for this change.

Go to: https://github.com/CryptoLifeCrisis/ravenproject.github.io/blob/patch-1/_data/wallets.yml

Add the code:

  • name: Magic Wallet
    logo: /assets/img/pages/wallet/magic-wallet.png
    url: https://x.com/magicwalletapp/
    asset-support: true
    platforms:

    • app-store-badge
    • google-play-badge

Then

Go to: https://github.com/CryptoLifeCrisis/ravenproject.github.io/tree/patch-1/assets/img/pages/wallet

Add the image.

Then

Cancel this merge, and make a new merge.

magic-wallet

I'm trying to replace the dead links when you click the "Download on the App Store" & "Get it on Google Play" buttons just under the "App Downloads With Asset Support" Heading.

@corviato1
Copy link

I see what you mean. In that case, it is probably best to just remove those two buttons in between "App Downloads With Asset Support" and "3rd Party Wallets". The text "App Downloads With Asset Support" should also be removed. Then add a 6th tag for Asset Aware that can be added for each wallet that supports assets.

If you can make the changes, or make an image for an Asset Aware tag, that would be cool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants