Removed 'Result'

Razz4780 · Nov 25, 2024 · 81fd35f · 81fd35f
1 parent 705998e
commit 81fd35f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/changelog.d/+type-fix.internal.md b/changelog.d/+type-fix.internal.md
@@ -0,0 +1 @@
+Fixed return type of a function in mirrord-operator client code.
diff --git a/mirrord/kube/src/resolved.rs b/mirrord/kube/src/resolved.rs
@@ -463,17 +463,15 @@ impl ResolvedTarget<true> {
         api_version: &str,
         plural: &str,
         url_path: &str,
-    ) -> Result<String, KubeApiError> {
+    ) -> String {
         let name = self.urlfied_name();
         let namespace = self.namespace().unwrap_or("default");
 
-        let url = if use_proxy {
+        if use_proxy {
             format!("/apis/{api_version}/proxy/namespaces/{namespace}/{plural}/{name}?on_concurrent_steal={concurrent_steal}&connect=true")
         } else {
             format!("{url_path}/{name}?on_concurrent_steal={concurrent_steal}&connect=true")
-        };
-
-        Ok(url)
+        }
     }
 
     pub fn urlfied_name(&self) -> String {

diff --git a/mirrord/operator/src/client.rs b/mirrord/operator/src/client.rs
@@ -626,7 +626,7 @@ impl OperatorApi<PreparedClientCert> {
                 &TargetCrd::api_version(&()),
                 &TargetCrd::plural(&()),
                 &TargetCrd::url_path(&(), target.namespace()),
-            )?
+            )
         };
 
         tracing::debug!("connect_url {connect_url:?}");