Add OSX to Travis build matrix #3331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fantastic! Thanks, Mark. |
Closed
mattdowle
added a commit
that referenced
this pull request
Mar 2, 2019
vincentvanhees
added a commit
to wadpac/GGIR
that referenced
this pull request
Oct 5, 2019
m-patterson
pushed a commit
to m-patterson/GGIR
that referenced
this pull request
May 11, 2020
vincentvanhees
added a commit
to wadpac/GGIR
that referenced
this pull request
Jun 18, 2020
muschellij2
pushed a commit
to muschellij2/GGIR
that referenced
this pull request
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3326.
In this PR the Travis configuration file has been updated to expand the Travis build matrix to OSX. In order to compile
data.tableon Travis OSX, an OpenMP enabled compiler is required, so thellvmhomebrew package is installed before running R CMD build. Also, global variables LDFLAGS and CFLAGS were added (for OSX) as described in thedata.tablewiki documentation.In addition to adding OSX, also the previous major release and R-devel builds of R were selected in the Travis build matrix. The OSX R-devel build was explicitly excluded from the matrix because Travis is currently not installing R-devel correctly. The total number of Travis builds is now 5 for each commit on the master branch.
As can be seen from the Travis OSX build output here, the OSX build is executed successfully. The total build time on OSX is usually a little longer than for Linux (in this case 14-16 minutes as compared to 10 for Linux)
If the previous major release and R-devel builds are not required, the
r:field can be removed from travis.yml.Note that code coverage is now calculated on all 5 builds, we could adapt the after success: field to run the coverage only on a linux/release build.
Thanks!