Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis do only 2 builds #3360

Merged
merged 1 commit into from
Feb 5, 2019
Merged

travis do only 2 builds #3360

merged 1 commit into from
Feb 5, 2019

Conversation

jangorecki
Copy link
Member

@jangorecki jangorecki commented Feb 5, 2019

Closes #3357
it takes now 20min. Osx build is slow, takes 15min, probably because of installing llvm each time. @MarcusKlik any idea if we can cache that somehow?

language: r
dist: trusty
sudo: required
cache: packages
warnings_are_errors: true
r_check_args: ""
# empty r_check_args to turn off --as-cran (on by default) as that can be slow
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_R_CHECK_CRAN_INCOMING_REMOTE_=false defined below should resolve problem of slow --as-cran

exclude:
- r: devel # exclude osx r-devel build as it is currently unstable
os: osx

before_install:
- if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then brew install llvm &&
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally this install llvm we would like to speed up

@MarcusKlik
Copy link
Contributor

MarcusKlik commented Feb 5, 2019

Hi @jangorecki ,

yes, I see that the llvm installation takes almost 5 minutes, that's quite long!
The same is true for the brew update command at the start of the build, that one also takes a bite out of the total running time.

We could cache the homebrew directory to cache the homebrew package downloads:

cache:
  directories:
    - $HOME/Library/Caches/Homebrew

before_cache:
  - brew cleanup

But as Travis stores the cache at a storage provider (see this doc), I don't think that downloading from the cache will be much faster than a direct download.

Also, following the Travis documentation on caching it seems that we should be able to cache the llvm installation directory itself, but somehow homebrew fails to install llvm correctly on the cached (initially empty) directory.

Some more testing to be done I think...

@mattdowle mattdowle changed the title travis do only 2 builds, closes #3357 travis do only 2 builds Feb 5, 2019
@mattdowle mattdowle added this to the 1.12.2 milestone Feb 5, 2019
@mattdowle mattdowle merged commit a0895e3 into master Feb 5, 2019
@mattdowle mattdowle deleted the travis-2-jobs branch February 5, 2019 23:52
@jangorecki
Copy link
Member Author

Thanks @MarcusKlik for detailed answer on that. I think we can also remove test coverage report from OSX build. It takes 330s and linux test coverage should be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants