Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shift on matrix: news and improve error #5462

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Conversation

jangorecki
Copy link
Member

closes #5287

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6bde008) 97.46% compared to head (2592ad0) 99.51%.

❗ Current head 2592ad0 differs from pull request most recent head cafb272. Consider uploading reports for the commit cafb272 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5462      +/-   ##
==========================================
+ Coverage   97.46%   99.51%   +2.04%     
==========================================
  Files          80       80              
  Lines       14820    14770      -50     
==========================================
+ Hits        14445    14698     +253     
+ Misses        375       72     -303     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jangorecki jangorecki added this to the 1.15.0 milestone Nov 6, 2023
@jangorecki jangorecki changed the title news and improve error shift on matrix: news and improve error Nov 7, 2023
@jangorecki jangorecki merged commit a40ec8e into master Dec 8, 2023
2 of 3 checks passed
@jangorecki jangorecki deleted the no-coerce-matrix branch December 8, 2023 16:23
@ben-schwen
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shift no longer works on matrix type under 1.14.3
3 participants