-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to pkgdown Bootstrap 5 template #5505
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5505 +/- ##
=======================================
Coverage 97.46% 97.46%
=======================================
Files 80 80
Lines 14822 14822
=======================================
Hits 14447 14447
Misses 375 375 ☔ View full report in Codecov by Sentry. |
@jangorecki Could you take a look at this? |
LGTM |
Could you merge this? |
Yes, we will merge. We are now on track to get data.table code contribution running smoothly. You may expect to wait for 1.15.99 to have it merged. Please see #5385 for justification. |
Any idea why this is not the default in pkgdown? |
This is a breaking change and we just need to opt in, check the pkgdown release notes. |
Anyway, this is not a major change and I see no reason why it cannot be merged immediately. |
Website looks much better on the mobile browser now |
Great! Thanks for merging this. |
Close #5503
The switch to bs5 will allow for search within the site, which will be very useful for users.
It will look like the following and a search window will be added in the upper right corner.
This PR is a small change to the pkgdown site configuration only; there are no changes to the document itself or to the R code.
How to test?
pkgdown::build_site()
function on the project root.