Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add subset and dogroups support for columns of type expression #5631

Merged
merged 4 commits into from
Sep 8, 2024

Conversation

ben-schwen
Copy link
Member

Closes #5596

@MichaelChirico MichaelChirico self-requested a review as a code owner September 4, 2024 04:51
@MichaelChirico MichaelChirico added this to the 1.17.0 milestone Sep 4, 2024
NEWS.md Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Sep 4, 2024

Comparison Plot

Generated via commit 2d019e5

Download link for the artifact containing the test results: ↓ atime-results.zip

Time taken to finish the standard R installation steps: 11 minutes and 29 seconds

Time taken to run atime::atime_pkg on the tests: 6 minutes and 38 seconds

@MichaelChirico
Copy link
Member

Thanks! Narrowed the NEWS item to signal expression is not fully-supported as a column type, and moved it to NEW FEATURES since I don't think it was really a bug before, just not supported.

@MichaelChirico MichaelChirico merged commit 6a2bf2e into master Sep 8, 2024
8 checks passed
@MichaelChirico MichaelChirico deleted the subset_expression branch September 8, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

column type 'expression' not supported by data.table subset
2 participants