Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup pkgup GH actions workflow #5690

Merged
merged 6 commits into from
Nov 5, 2023
Merged

setup pkgup GH actions workflow #5690

merged 6 commits into from
Nov 5, 2023

Conversation

jangorecki
Copy link
Member

@jangorecki jangorecki commented Sep 20, 2023

This uses https://github.com/jangorecki/pkgup template for simple and yet artifact rich GH Action release pipeline. Requires setting of Pages to Github Actions, rather than gh-pages branch, as most likely is set now..
Once merged we should update CI documentation in .ci/README.md. I feel it is already outdated.

@jangorecki jangorecki added the ci label Sep 20, 2023
@jangorecki jangorecki changed the title setup pkgup GH actions workflo setup pkgup GH actions workflow Sep 21, 2023
@MichaelChirico
Copy link
Member

@jangorecki @tdhock any thoughts on reviewing this now to make sure all the pending PRs have proper CI?

I lean yes but it's slightly less trivial +"no code" than the other PRs I'm reviewing now, want to double-check first.

@MichaelChirico
Copy link
Member

Also @jangorecki PTAL at #5632 which is closely related.

@jangorecki
Copy link
Member Author

jangorecki commented Nov 3, 2023

If we leave GLCI then we need to move our pkgdown website to GHCI as well, but that is not a blocker. Having dev pkg being released somewhere that update_dev_pkg can use is a blocker, so that we can update url already in patch release 1.14.10..
We can merge this PR for the moment, and after 1.14.10 work on adding pkgdown, and setting redirection from r-datatable.com to GH page.

@jangorecki
Copy link
Member Author

jangorecki commented Nov 3, 2023

In settings-pages I have switched github pages to be deployed from GH actions rather than gh-pages git branch.

PR is ready to merge, after merging we can try out #5719
Once in master it will be able to deploy to pages

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a glance one might confuse pkgdown/pkgup as being closely related, maybe rename this workflow e.g. 'upload-pkg-binary'?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is pkg sources only, and pkgup stands for putting a package up. I will document CI once we finish releasing to CRAN, so it will be clear.

Copy link
Member

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to 'pkgup' naming is not required, Approving now if you want to skip that. O/w will re-approve on update.

@jangorecki jangorecki merged commit ac2b737 into master Nov 5, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants