-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
custom data.frame classes redirected to as.data.frame before as.data.table #5700
Conversation
Hi @jangorecki would you mind summarizing what needs to be done to get this ready for review? That way someone else could have a go at sewing it up if you don't get to it first. Thanks! |
Examine why test fails, if still fails. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am OK to merge with Jan's ack (and a NEWS entry).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5700 +/- ##
=======================================
Coverage 98.62% 98.62%
=======================================
Files 79 79
Lines 14630 14631 +1
=======================================
+ Hits 14429 14430 +1
Misses 201 201 ☔ View full report in Codecov by Sentry. |
Generated via commit 9633663 Download link for the artifact containing the test results: ↓ atime-results.zip
|
closes #5699