Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom data.frame classes redirected to as.data.frame before as.data.table #5700

Merged
merged 8 commits into from
Jan 17, 2025

Conversation

jangorecki
Copy link
Member

closes #5699

R/as.data.table.R Outdated Show resolved Hide resolved
@jangorecki jangorecki requested a review from mattdowle as a code owner December 9, 2023 14:00
@jangorecki jangorecki added this to the 1.16.0 milestone Dec 9, 2023
inst/tests/tests.Rraw Outdated Show resolved Hide resolved
@jangorecki jangorecki added the WIP label Dec 9, 2023
@MichaelChirico MichaelChirico marked this pull request as draft February 19, 2024 02:45
@MichaelChirico MichaelChirico modified the milestones: 1.16.0, 1.17.0 Jul 10, 2024
@MichaelChirico
Copy link
Member

Hi @jangorecki would you mind summarizing what needs to be done to get this ready for review? That way someone else could have a go at sewing it up if you don't get to it first. Thanks!

@MichaelChirico MichaelChirico modified the milestones: 1.17.0, 1.18.0 Dec 3, 2024
@jangorecki
Copy link
Member Author

Examine why test fails, if still fails.

@MichaelChirico MichaelChirico marked this pull request as ready for review December 4, 2024 07:33
Copy link
Member

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am OK to merge with Jan's ack (and a NEWS entry).

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.62%. Comparing base (d263924) to head (ae8c6ff).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5700   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files          79       79           
  Lines       14630    14631    +1     
=======================================
+ Hits        14429    14430    +1     
  Misses        201      201           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 4, 2024

Comparison Plot

Generated via commit 9633663

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 4 minutes and 39 seconds
Installing different package versions 7 minutes and 51 seconds
Running and plotting the test cases 2 minutes and 20 seconds

@MichaelChirico MichaelChirico merged commit 1eec7f3 into master Jan 17, 2025
8 of 9 checks passed
@MichaelChirico MichaelChirico deleted the custom-class-dt branch January 17, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

as.data.table should remove extra attributes from extended data.frames
2 participants