unexport and undocument DT(), closes #5472 #5730
Conversation
jangorecki
had a problem deploying
to
github-pages
GitHub Actions
Failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5730 +/- ##
==========================================
- Coverage 97.46% 97.46% -0.01%
==========================================
Files 80 80
Lines 14820 14814 -6
==========================================
- Hits 14445 14439 -6
Misses 375 375 ☔ View full report in Codecov by Sentry. |
|
inviting @eddelbuettel to review, as you mentioned that you use |
There was a problem hiding this comment.
Not sure how much I can say here so I just leave a comment -- I got used to the exported version that I use(d) in some workflows / experiments here. I like its compactness, and forcing data.table::DT is much less attractive, as is having to make a local copy.
IINM the intention is to un-export it to remove it as a block to releasing 1.15.0, then export it again after fixing the pending issues. We might also export it in 1.15.99 dev version after a CRAN release. |
|
Yes, the issue explains:
|
| @@ -8,6 +8,7 @@ if (exists("test.data.table", .GlobalEnv, inherits=FALSE)) { | |||
| if ((tt<-compiler::enableJIT(-1))>0) | |||
| cat("This is dev mode and JIT is enabled (level ", tt, ") so there will be a brief pause around the first test.\n", sep="") | |||
| rm_all = function() {} | |||
| DTfun = DT ## otherwise DT would be re-defined by many tests | |||
There was a problem hiding this comment.
this is a good point... exporting DT() will open up many accidental "object of type closure is not subsettable" issues when user makes an ad hoc object named DT but runs DT[...] in a context where it's only defined as data.table::DT(). somewhat unfortunate that DT and dt are both taken as placeholder object names in exploratory work.
closes #5472
Based on two PRs
#5104
#5113
functionality is still there, it is just not exported and documented.
I encourage users interested in this functionality to use
and play with it. Just be aware that there are couple open issue that affects DT() as of now, all listed in DT()