Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list column to null data.table #5739

Merged
merged 9 commits into from
May 19, 2024

Conversation

ben-schwen
Copy link
Member

Closes #5738

  • fix
  • tests
  • NEWS

Copy link

github-actions bot commented May 17, 2024

Comparison Plot

Generated via commit a710c30

Download link for the artifact containing the test results: ↓ atime-results.zip

Time taken to finish the standard R installation steps: 11 minutes and 58 seconds

Time taken to run atime::atime_pkg on the tests: 3 minutes and 39 seconds

NEWS.md Outdated Show resolved Hide resolved
src/assign.c Outdated Show resolved Hide resolved
@MichaelChirico
Copy link
Member

LGTM, superficial fixes only, thanks!

ben-schwen and others added 3 commits May 19, 2024 11:51
Co-authored-by: Michael Chirico <[email protected]>
Co-authored-by: Michael Chirico <[email protected]>
@MichaelChirico MichaelChirico merged commit a33b334 into master May 19, 2024
3 of 4 checks passed
@MichaelChirico MichaelChirico deleted the add_non_atomic_col_nulldatatable branch May 19, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot add list column to empty data.table
2 participants