Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GOVERNANCE.md document #5772

Merged
merged 31 commits into from
Dec 14, 2023
Merged

add GOVERNANCE.md document #5772

Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
472893d
first draft GOVERNANCE.md
tdhock Nov 28, 2023
cc58300
more contributions
tdhock Nov 30, 2023
9256157
run-time signals are accessible
tdhock Nov 30, 2023
8027427
Update GOVERNANCE.md
tdhock Nov 30, 2023
a812be4
CRAN maintainer responsible for responding
tdhock Nov 30, 2023
7eb8c76
ok -> OK
tdhock Nov 30, 2023
7070a54
remove comma
tdhock Nov 30, 2023
45202ee
various updates based on comments from Jan and Michael
tdhock Nov 30, 2023
0eb3cde
process for changing scope
tdhock Nov 30, 2023
8c501a0
user-friendly
tdhock Dec 5, 2023
fa7b5b6
rbindlist
tdhock Dec 5, 2023
1b3c844
add history, other updates as suggested by reviewers
tdhock Dec 8, 2023
9d502ac
sorting -> common functions
tdhock Dec 12, 2023
708c7ff
summarize by and grouping sets
tdhock Dec 12, 2023
2ed51f5
add set ops
tdhock Dec 12, 2023
505c34c
subset -> filtering
tdhock Dec 12, 2023
232eb05
code -> substantial
tdhock Dec 12, 2023
83ef82c
backquotes
tdhock Dec 12, 2023
5f9f3da
z version includes devel
tdhock Dec 12, 2023
279e6ed
PR 3 bullets
tdhock Dec 12, 2023
8870eae
Merge branch 'governance' of https://github.com/Rdatatable/data.table…
tdhock Dec 12, 2023
eb084ac
ben reviewed
tdhock Dec 12, 2023
7ff67f4
rm modeling
tdhock Dec 13, 2023
05e16e7
efficiency first
tdhock Dec 14, 2023
85fb6dc
Data->data
tdhock Dec 14, 2023
57ccd73
remove other roles
tdhock Dec 14, 2023
d14db6b
different person -> someone other
tdhock Dec 14, 2023
c7ebe5a
same as -> often will be
tdhock Dec 14, 2023
d9a9c30
hotfix/patch should not include new features
tdhock Dec 14, 2023
c6a282e
rm repetition
tdhock Dec 14, 2023
1ef2f45
Merge branch 'governance' of https://github.com/Rdatatable/data.table…
tdhock Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
hotfix/patch should not include new features 
Co-authored-by: Michael Chirico <chiricom@google.com>
  • Loading branch information
@tdhock @MichaelChirico
tdhock and MichaelChirico authored Dec 14, 2023
commit d9a9c30e9049a3b395ed33bc856c82d7c27c5856
2 changes: 1 addition & 1 deletion GOVERNANCE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ A pull request can be merged by any committer, if there is one approving review,
## CRAN updates

* Regular CRAN releases should ideally occur twice per year, and can include new features.
* A hotfix/patch CRAN release should occur when CRAN asks for one, at which time the CRAN maintainer should post an issue on github, and ask others to help fix/prepare the release.
* A hotfix/patch CRAN release should occur when CRAN asks for one, at which time the CRAN maintainer should post an issue on github, and ask others to help fix/prepare the release. It should not include new features.
* Both kinds of releases should be discussed in an issue, and the release should happen only if there is Consensus among active Reviewers and Committers.
* It is the responsibility of the CRAN maintainer to ensure quality prior to release. This includes CRAN checks, unit tests, performance tests, etc, and these tasks can be delegated to others.

Expand Down