-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow rbind for integer64 and character/complex/vector #5874
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5874 +/- ##
=======================================
Coverage 97.47% 97.47%
=======================================
Files 80 80
Lines 14831 14831
=======================================
Hits 14457 14457
Misses 374 374 ☔ View full report in Codecov by Sentry. |
Will do at the weekend |
Generated via commit bdcfd2b Download link for the artifact containing the test results: ↓ atime-results.zip Time taken to finish the standard R installation steps: 11 minutes and 27 seconds Time taken to run |
Funny it took till now to find the issue with test 2265 re-attaching {bit64} incorrectly. It did not show up under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why always using coerceAs()
doesn't "just work" but switching broke a lot of tests; left for future exercise :)
Closes #5504