-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Imports from Blanket to Selective Import for Improved Code Maintainability #5988
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5988 +/- ##
=======================================
Coverage 97.49% 97.49%
=======================================
Files 80 80
Lines 14861 14861
=======================================
Hits 14488 14488
Misses 373 373 ☔ View full report in Codecov by Sentry. |
@MichaelChirico plz checkout this PR if you have time :) |
thanks! please remove quotes ( |
@MichaelChirico I removed quotes from everywhere except "S3Part<-" because it was causing some error. |
right, NAMESPACE needs to parse as R, so |
Sorry, one more change -- please add yourself to LGTM otherwise, thanks! |
Done 👍 |
Thanks for the PR! You've been added as a project member to facilitate future collaboration! Check your e-mail. You'll be able to create branches directly from this repo going forward. Thanks again! |
Summary:
This pull request updates the imports in the codebase to use selective imports instead of blanket imports for better maintainability and reduced risk of conflicts.
Changes Made:
import(methods)
withimportFrom("methods", "S3Part<-", "slotNames")
.import(utils)
withimportFrom("utils", "tail", "head", "packageVersion", "capture.output", "contrib.url", "download.file", "flush.console", "getS3method", "untar", "unzip")
.import(stats)
withimportFrom("stats", "na.omit", "as.formula", "setNames", "terms", "time")
.This PR Closes #5970