Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate + apply some linters #6124

Merged
merged 6 commits into from
May 6, 2024
Merged

Activate + apply some linters #6124

merged 6 commits into from
May 6, 2024

Conversation

MichaelChirico
Copy link
Member

Still not trying to touch inst/tests/tests.Rraw too much, but these small-scale changes should be OK to move forward.

@MichaelChirico MichaelChirico requested a review from tdhock as a code owner May 4, 2024 21:05
Copy link

github-actions bot commented May 4, 2024

Comparison Plot

Generated via commit bb2f3e2

Download link for the artifact containing the test results: ↓ atime-results.zip

Time taken to finish the standard R installation steps: 11 minutes and 27 seconds

Time taken to run atime::atime_pkg on the tests: 3 minutes and 16 seconds

Copy link
Member

@tdhock tdhock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MichaelChirico MichaelChirico merged commit 014c82f into master May 6, 2024
4 checks passed
@MichaelChirico MichaelChirico deleted the lint-activate branch May 6, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants