-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export masks for NSE-only constructs .
, J
, patterns
and measure
#6125
Conversation
Generated via commit ea84607 Download link for the artifact containing the test results: ↓ atime-results.zip Time taken to finish the standard R installation steps: 11 minutes and 49 seconds Time taken to run |
please edit your first comment in this PR which says "This PR closes #5604 #5277." (two issues linked on one line) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please add a NEWS item?
done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok looks good to me but please wait for a second review from @MichaelChirico @jangorecki or @ben-schwen
@@ -27,7 +27,7 @@ export(tstrsplit) | |||
export(frank) | |||
export(frankv) | |||
export(address) | |||
export(.SD,.N,.I,.GRP,.NGRP,.BY,.EACHI) | |||
export(.SD,.N,.I,.GRP,.NGRP,.BY,.EACHI, ., J, measure, patterns) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: I imagine this (.
) will break some revdeps. Let's see.
Co-authored-by: Michael Chirico <[email protected]>
Co-authored-by: Michael Chirico <[email protected]>
Co-authored-by: Michael Chirico <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This pull request addresses issue #5604 and #5277 , which aims to export masks for all non-standard evaluation (NSE) only constructs within
[
andmelt()
functions. Currently, only.N
,.I
,.GRP
,.GRPI
,.SD
, and:=
are exported, but this PR extends the export functionality to include.
,J
,measure
andpatterns
.Namespace
.This PR closes #5604
closes #5277