Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove targetDesc helper in assign.c in favor of splitting cases for i18n #6489

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

MichaelChirico
Copy link
Member

Gave up on the grammatical case-switching approach suggested here:

#6482 (comment)

In the end dropping targetDesc() altogether means about a dozen extra lines, I think the added clarity is worth it. As seen here, it also unconstrains us from shoehorning both branches into the same format, potentially adding clarity to the message.

@MichaelChirico MichaelChirico added the translation issues/PRs related to message translation projects label Sep 9, 2024
Copy link

github-actions bot commented Sep 9, 2024

Comparison Plot

Generated via commit 9266548

Download link for the artifact containing the test results: ↓ atime-results.zip

Time taken to finish the standard R installation steps: 12 minutes and 6 seconds

Time taken to run atime::atime_pkg on the tests: 7 minutes and 1 seconds

Copy link
Member

@tdhock tdhock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine. i wonder if it is worth adding a comment about the history with targetDesc? (ok if you dont think it is necessary)

@MichaelChirico
Copy link
Member Author

adding a comment about the history with targetDesc

In the code somewhere? (as a comment on the line where it used to be declared?) or here in the PR?

@MichaelChirico
Copy link
Member Author

I don't think a code comment is needed (it was not a particularly important part of the code, no "historic" relevance, and git is here for future archeologists), and we can edit the PR if needed later; submitting now.

@MichaelChirico MichaelChirico merged commit 038ce2b into master Sep 11, 2024
7 of 8 checks passed
@MichaelChirico MichaelChirico deleted the i18n-grammar branch September 11, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation issues/PRs related to message translation projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants