Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update GLCI (warnings + docs) #6586

Merged
merged 13 commits into from
Nov 2, 2024
Merged

update GLCI (warnings + docs) #6586

merged 13 commits into from
Nov 2, 2024

Conversation

ben-schwen
Copy link
Member

@ben-schwen ben-schwen commented Oct 20, 2024 •
edited
Loading

  • Removes known false positives in CI
  • Updates .CI readme

CI results

@codecov Codecov
Copy link

codecov bot commented Oct 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.60%. Comparing base (e5b845e) to head (d783380).
Report is 5 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6586   +/-   ##
=======================================
  Coverage   98.60%   98.60%           
=======================================
  Files          79       79           
  Lines       14516    14516           
=======================================
  Hits        14314    14314           
  Misses        202      202

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 20, 2024 •
edited
Loading

Comparison Plot

Generated via commit 07029a6

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 3 minutes and 24 seconds
Installing different package versions 7 minutes and 28 seconds
Running and plotting the test cases 2 minutes and 9 seconds

@ben-schwen ben-schwen marked this pull request as ready for review October 20, 2024 12:51
@ben-schwen ben-schwen changed the title fix CI warnings improve CI (warnings + docs) Oct 20, 2024
@ben-schwen ben-schwen changed the title improve CI (warnings + docs) update GLCI (warnings + docs) Oct 20, 2024
MichaelChirico
MichaelChirico reviewed Oct 21, 2024
View reviewed changes
src/freadR.h Outdated Show resolved Hide resolved
Anirban166
Anirban166 reviewed Oct 25, 2024
View reviewed changes
.ci/README.md Outdated Show resolved Hide resolved
.ci/README.md Outdated Show resolved Hide resolved
jangorecki
jangorecki approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@jangorecki jangorecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.ci/README.md Show resolved Hide resolved
MichaelChirico
MichaelChirico reviewed Oct 25, 2024
View reviewed changes
.ci/README.md Outdated Show resolved Hide resolved
MichaelChirico
MichaelChirico reviewed Oct 25, 2024
View reviewed changes
.ci/README.md Outdated Show resolved Hide resolved
@ben-schwen ben-schwen mentioned this pull request Oct 26, 2024
Open
@ben-schwen ben-schwen merged commit 6f85f86 into master Nov 2, 2024
10 of 11 checks passed
@ben-schwen ben-schwen deleted the CI_warnings branch November 2, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anirban166 Anirban166 Anirban166 left review comments

@MichaelChirico MichaelChirico MichaelChirico left review comments

@jangorecki jangorecki jangorecki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ben-schwen @jangorecki @MichaelChirico @Anirban166