Simplify error for := under with=FALSE #6834
Open
+3
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 23, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
MichaelChirico
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## depr-inplace #6834 +/- ##
================================================
- Coverage 98.64% 98.64% -0.01%
================================================
Files 79 79
Lines 14638 14637 -1
================================================
- Hits 14440 14439 -1
Misses 198 198 ☔ View full report in Codecov by Sentry. |
|
Generated via commit 7f5a437 Download link for the artifact containing the test results: ↓ atime-results.zip
|
ben-schwen
reviewed
Mar 8, 2025
| # TODO(>=1.18.0): Simplify this error | ||
| stopf("with=FALSE together with := was deprecated in v1.9.4 released Oct 2014; this has been warning since v1.15.0. Please wrap the LHS of := with parentheses; e.g., DT[,(myVar):=sum(b),by=a] to assign to column name(s) held in variable myVar. See ?':=' for other examples.") | ||
| } | ||
| if (jsub %iscall% ":=") stopf("`:=` is only supported under with=TRUE.") |
There was a problem hiding this comment.
Maybe keep the
See ?':=' for other examples."
although a bit superfluous?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.